FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: cherry-pick upstream ICU fix by mathiasbynens · Pull Request #16931 · nodejs/node · GitHub

/ node Public

deps: cherry-pick upstream ICU fix - #16931

Closed
mathiasbynens wants to merge 1 commit into
nodejs:masterfrom
mathiasbynens:icu
ConversationCommits (1)ChecksFiles changed
Closed

deps: cherry-pick upstream ICU fix#16931
mathiasbynens wants to merge 1 commit into
nodejs:masterfrom
mathiasbynens:icu

Conversation

mathiasbynens commented Nov 10, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

ICU 60.1 has a bug resulting in incorrect Script_Extensions data for 5 characters. http://bugs.icu-project.org/trac/ticket/13462

Upstream patch: http://bugs.icu-project.org/trac/changeset/40667

Ref. https://bugs.chromium.org/p/v8/issues/detail?id=4743#c54.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included (upstream)
  • documentation is changed or added (N/A)
  • commit message follows commit guidelines
Affected core subsystem(s)

deps

mathiasbynens commented Nov 10, 2017

Copy link
Copy Markdown
Contributor Author

This is a follow-up to #16876. cc @srl295

mscdex added the i18n-api Issues and PRs related to the i18n implementation. label Nov 10, 2017
srl295 approved these changes Nov 10, 2017
View reviewed changes

srl295 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sure… I had not realized that this would be a "code" change only, my concern was mostly over data split.

This way it's overwritten if you rebuild node to download ICU, but that's where things are at present.

refack approved these changes Nov 10, 2017
View reviewed changes

refack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Rubber-stamp

srl295 mentioned this pull request Nov 10, 2017
Closed
fhinkel approved these changes Nov 11, 2017
View reviewed changes

fhinkel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Rubberstamp LGTM

bricss mentioned this pull request Nov 13, 2017
Merged
mhdawson approved these changes Nov 16, 2017
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Rubber stamp LGTM

mhdawson commented Nov 16, 2017

Copy link
Copy Markdown
Member

CI run: https://ci.nodejs.org/job/node-test-pull-request/11487/

addaleax commented Nov 18, 2017

Copy link
Copy Markdown
Member

Landed in 42bdb66

addaleax closed this Nov 18, 2017
addaleax pushed a commit that referenced this pull request Nov 18, 2017
deps: cherry-pick upstream ICU fix
42bdb66 
ICU 60.1 has a bug resulting in incorrect Script_Extensions data
for 5 characters.
http://bugs.icu-project.org/trac/ticket/13462

Upstream patch:
http://bugs.icu-project.org/trac/changeset/40667

Refs: https://bugs.chromium.org/p/v8/issues/detail?id=4743#c54
PR-URL: #16931
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
ilovezfs mentioned this pull request Dec 5, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
deps: cherry-pick upstream ICU fix
24bb99a 
ICU 60.1 has a bug resulting in incorrect Script_Extensions data
for 5 characters.
http://bugs.icu-project.org/trac/ticket/13462

Upstream patch:
http://bugs.icu-project.org/trac/changeset/40667

Refs: https://bugs.chromium.org/p/v8/issues/detail?id=4743#c54
PR-URL: #16931
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins mentioned this pull request Dec 12, 2017
Merged

srl295 commented Dec 14, 2017

Copy link
Copy Markdown
Member

FWIW this upstream fix landed in ICU 60.2. PR coming soon…

srl295 mentioned this pull request Dec 14, 2017
Closed
2 tasks
MylesBorins added baking-for-lts PRs that need to wait before landing in a LTS release. lts-watch-v6.x labels Dec 19, 2017
srl295 added a commit that referenced this pull request Jan 18, 2018
deps: ICU 60.2 bump
e42708c 
- Update to Maintainance ICU 60.2
- CLDR 32.0.1
- http://site.icu-project.org/download/60#TOC-ICU-60.2-bug-fixes
- Subsumes #16931

PR-URL: #17687
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
srl295 added a commit to srl295/node that referenced this pull request Jan 18, 2018
deps: ICU 60.2 bump
c0aee51 
- Update to Maintainance ICU 60.2
- CLDR 32.0.1
- http://site.icu-project.org/download/60#TOC-ICU-60.2-bug-fixes
- Subsumes nodejs#16931

PR-URL: nodejs#17687
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 20, 2018
deps: ICU 60.2 bump
9e7f863 
- Update to Maintainance ICU 60.2
- CLDR 32.0.1
- http://site.icu-project.org/download/60#TOC-ICU-60.2-bug-fixes
- Subsumes #16931

PR-URL: #17687
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
deps: ICU 60.2 bump
c070fbc 
- Update to Maintainance ICU 60.2
- CLDR 32.0.1
- http://site.icu-project.org/download/60#TOC-ICU-60.2-bug-fixes
- Subsumes nodejs#16931

PR-URL: nodejs#17687
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
tniessen removed the baking-for-lts PRs that need to wait before landing in a LTS release. label Jan 21, 2020
This was referenced Mar 9, 2020
Open
Open
snyk-bot mentioned this pull request Jul 15, 2022
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
srl295 srl295 approved these changes
+3 more reviewers
refack refack approved these changes
fhinkel fhinkel approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

i18n-api Issues and PRs related to the i18n implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL