src: explain implementation of vm module - #16962
Closed
fhinkel wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
cjihrig
approved these changes
Nov 12, 2017
Comment thread
src/node_contextify.cc
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
exectues -> executes
Sorry, something went wrong.
targos
approved these changes
Nov 12, 2017
Comment thread
src/node_contextify.cc
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
archieved -> achieved
Sorry, something went wrong.
gireeshpunathil
approved these changes
Nov 12, 2017
fhinkel
force-pushed
the
nov/explain-interceptors
branch
from
09a86fc to
43a1bb2
Compare
November 12, 2017 14:19
The vm module uses interceptors on the object template. This is not straight forward and a comment in the source will help the next person working on this.
fhinkel
force-pushed
the
nov/explain-interceptors
branch
from
43a1bb2 to
4982514
Compare
November 12, 2017 14:24
jasnell
approved these changes
Nov 12, 2017
jasnell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, this shouldn't need to wait 48 hours to land.
Sorry, something went wrong.
addaleax
approved these changes
Nov 12, 2017
Copy link
Copy Markdown
Member
|
Since this is only adding a comment, just going to lint: https://ci.nodejs.org/job/node-test-linter/13499/ |
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
Nov 12, 2017
The vm module uses interceptors on the object template. This is not straight forward and a comment in the source will help the next person working on this. PR-URL: #16962 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
evanlucas
pushed a commit
that referenced
this pull request
Nov 13, 2017
The vm module uses interceptors on the object template. This is not straight forward and a comment in the source will help the next person working on this. PR-URL: #16962 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
Copy link
Copy Markdown
Contributor
|
Should this be backported to v6.x-staging or v8.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vm module uses interceptors on the object template. This is not
straight forward and a comment in the source will help the next
person (and future me) working on this.
Checklist
Affected core subsystem(s)
src - but only adding a comment