FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: turn inspector raw pointer into unique_ptr by fhinkel · Pull Request #16974 · nodejs/node · GitHub

/ node Public

src: turn inspector raw pointer into unique_ptr - #16974

Closed
fhinkel wants to merge 1 commit into
nodejs:masterfrom
fhinkel:nov/uniq_ptr_inspector
ConversationCommits (1)ChecksFiles changed
Closed

src: turn inspector raw pointer into unique_ptr#16974
fhinkel wants to merge 1 commit into
nodejs:masterfrom
fhinkel:nov/uniq_ptr_inspector

Conversation

fhinkel commented Nov 12, 2017

Copy link
Copy Markdown
Contributor

Use a unique pointer to make ownership clear.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

src: turn inspector raw pointer into unique_ptr
f3ba11c 
Use a unique pointer to make ownership clear.
nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 12, 2017

fhinkel commented Nov 13, 2017

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/11404/

fhinkel commented Nov 14, 2017

Copy link
Copy Markdown
Contributor Author

Landed in c07d127.

fhinkel closed this Nov 14, 2017
fhinkel added a commit that referenced this pull request Nov 14, 2017
src: turn inspector raw pointer into unique_ptr
c07d127 
Use a unique pointer to make ownership clear.

PR-URL: #16974
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
evanlucas pushed a commit that referenced this pull request Nov 14, 2017
src: turn inspector raw pointer into unique_ptr
71181b9 
Use a unique pointer to make ownership clear.

PR-URL: #16974
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
fhinkel mentioned this pull request Nov 15, 2017
Closed
2 tasks
fhinkel added a commit that referenced this pull request Nov 17, 2017
doc: mention smart pointers in Cpp style guide
0e1abb1 
Add rule for smart pointers, i.e., std::unique_ptr and std::shared_ptr,
to the Cpp style guide. Mostly copied from the Google style guide.

PR-URL: #17055
Ref: #16970
Ref: #16974
Ref: #17000
Ref: #17012
Ref: #17020
Ref: #17030
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins commented Nov 17, 2017

Copy link
Copy Markdown
Contributor

Does this make sense for 6.x or 8.x LTS? It lands cleanly on 8.x but will require a backport for 6.x

fhinkel commented Nov 17, 2017

Copy link
Copy Markdown
Contributor Author

I'd say let's not land the smart pointer changes.

bnoordhuis commented Nov 17, 2017

Copy link
Copy Markdown
Member

That's going to make future back-ports more difficult though.

fhinkel commented Nov 18, 2017

Copy link
Copy Markdown
Contributor Author

Makes sense. Changing the labels

MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
doc: mention smart pointers in Cpp style guide
03803ee 
Add rule for smart pointers, i.e., std::unique_ptr and std::shared_ptr,
to the Cpp style guide. Mostly copied from the Google style guide.

PR-URL: #17055
Ref: #16970
Ref: #16974
Ref: #17000
Ref: #17012
Ref: #17020
Ref: #17030
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn pushed a commit that referenced this pull request Dec 13, 2017
src: turn inspector raw pointer into unique_ptr
b1802ed 
Use a unique pointer to make ownership clear.

PR-URL: #16974
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
doc: mention smart pointers in Cpp style guide
f30fcdb 
Add rule for smart pointers, i.e., std::unique_ptr and std::shared_ptr,
to the Cpp style guide. Mostly copied from the Google style guide.

PR-URL: #17055
Ref: #16970
Ref: #16974
Ref: #17000
Ref: #17012
Ref: #17020
Ref: #17030
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
doc: mention smart pointers in Cpp style guide
706aab9 
Add rule for smart pointers, i.e., std::unique_ptr and std::shared_ptr,
to the Cpp style guide. Mostly copied from the Google style guide.

PR-URL: #17055
Ref: #16970
Ref: #16974
Ref: #17000
Ref: #17012
Ref: #17020
Ref: #17030
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn mentioned this pull request Dec 20, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
+2 more reviewers
eugeneo eugeneo approved these changes
TimothyGu TimothyGu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL