http,https,net,tls: return this from setTimeout methods by evanlucas · Pull Request #1699 · nodejs/node · GitHub

Modifies the setTimeout methods for the following prototypes:

http.ClientRequest
http.IncomingMessage
http.OutgoingMessage
http.Server
https.Server
net.Socket
tls.TLSSocket

Previously, the above functions returned undefined. They now return
this. This is useful for chaining function calls.

Related: #1657

Why is this semver-major?

Going from undefined to something looks more like a semver-minor to me. Also, I think https needs the same treatment?

Yea, I would think changing the return value of a function would be breaking regardless, but either way is fine by me.

Modifies the setTimeout methods for the following prototypes: - http.ClientRequest - http.IncomingMessage - http.OutgoingMessage - http.Server - https.Server - net.Socket - tls.TLSSocket Previously, the above functions returned undefined. They now return `this`. This is useful for chaining function calls.

Ok, updated tests to verify for https.Server and tls.TLSSocket as well

LGTM.

Let's land this one now, the other methods mentioned in #1657 can follow later. I think it's safe to say that we don't ever want to return anything else on the affected methods.

CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/682/

Looks like the usual unrelated windows and arm failures. I think it's good to merge.

Modifies the setTimeout methods for the following prototypes: - http.ClientRequest - http.IncomingMessage - http.OutgoingMessage - http.Server - https.Server - net.Socket - tls.TLSSocket Previously, the above functions returned undefined. They now return `this`. This is useful for chaining function calls. PR-URL: #1699 Reviewed-By: Roman Reiss <me@silverwind.io>

Landed in d4726cd with a slightly shorter commit title (ommited https to fit)

PR-URL: nodejs#1532 Notable Changes: * crypto: Diffie-Hellman key exchange (DHE) parameters ('dhparams') must now be 1024 bits or longer or an error will be thrown. A warning will also be printed to the console if you supply less than 2048 bits. See https://weakdh.org/ for further context on this security concern. (Shigeki Ohtsu) nodejs#1739. * node: A new --trace-sync-io command line flag will print a warning and a stack trace whenever a synchronous API is used. This can be used to track down synchronous calls that may be slowing down an application. (Trevor Norris) nodejs#1707. * node: To allow for chaining of methods, the setTimeout(), setKeepAlive(), setNoDelay(), ref() and unref() methods used in 'net', 'dgram', 'http', 'https' and 'tls' now return the current instance instead of undefined (Roman Reiss & Evan Lucas) nodejs#1699 nodejs#1768 nodejs#1779. * util: A significant speed-up (in the order of 35%) for the common-case of a single string argument to util.format(), used by console.log() (Сковорода Никита Андреевич) nodejs#1749.

PR-URL: nodejs#1532 Notable Changes: * crypto: Diffie-Hellman key exchange (DHE) parameters ('dhparams') must now be 1024 bits or longer or an error will be thrown. A warning will also be printed to the console if you supply less than 2048 bits. See https://weakdh.org/ for further context on this security concern. (Shigeki Ohtsu) nodejs#1739. * node: A new --trace-sync-io command line flag will print a warning and a stack trace whenever a synchronous API is used. This can be used to track down synchronous calls that may be slowing down an application. (Trevor Norris) nodejs#1707. * node: To allow for chaining of methods, the setTimeout(), setKeepAlive(), setNoDelay(), ref() and unref() methods used in 'net', 'dgram', 'http', 'https' and 'tls' now return the current instance instead of undefined (Roman Reiss & Evan Lucas) nodejs#1699 nodejs#1768 nodejs#1779. * npm: Upgraded to v2.10.1, release notes can be found in https://github.com/npm/npm/releases/tag/v2.10.1 and https://github.com/npm/npm/releases/tag/v2.10.0. * util: A significant speed-up (in the order of 35%) for the common-case of a single string argument to util.format(), used by console.log() (Сковорода Никита Андреевич) nodejs#1749.

PR-URL: #1777 Notable Changes: * crypto: Diffie-Hellman key exchange (DHE) parameters ('dhparams') must now be 1024 bits or longer or an error will be thrown. A warning will also be printed to the console if you supply less than 2048 bits. See https://weakdh.org/ for further context on this security concern. (Shigeki Ohtsu) #1739. * node: A new --trace-sync-io command line flag will print a warning and a stack trace whenever a synchronous API is used. This can be used to track down synchronous calls that may be slowing down an application. (Trevor Norris) #1707. * node: To allow for chaining of methods, the setTimeout(), setKeepAlive(), setNoDelay(), ref() and unref() methods used in 'net', 'dgram', 'http', 'https' and 'tls' now return the current instance instead of undefined (Roman Reiss & Evan Lucas) #1699 #1768 #1779. * npm: Upgraded to v2.10.1, release notes can be found in https://github.com/npm/npm/releases/tag/v2.10.1 and https://github.com/npm/npm/releases/tag/v2.10.0. * util: A significant speed-up (in the order of 35%) for the common-case of a single string argument to util.format(), used by console.log() (Сковорода Никита Андреевич) #1749.

Modifies the setTimeout methods for the following prototypes: - http.ClientRequest - http.IncomingMessage - http.OutgoingMessage - http.Server - https.Server - net.Socket - tls.TLSSocket Previously, the above functions returned undefined. They now return `this`. This is useful for chaining function calls. PR-URL: nodejs/node#1699 Reviewed-By: Roman Reiss <me@silverwind.io>

nodejs#1699 did not update documentation

Refs: nodejs#1699

Refs: nodejs#1699 PR-URL: nodejs#8356 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>

Refs: #1699 PR-URL: #8356 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>

evanlucas added http Issues or PRs related to the http subsystem. net Issues and PRs related to the net subsystem. semver-major PRs that contain breaking changes and should be released in the next major version. labels May 14, 2015

evanlucas removed the semver-major PRs that contain breaking changes and should be released in the next major version. label May 14, 2015

silverwind added the semver-minor PRs that contain new features and should be released in the next minor version. label May 14, 2015

evanlucas force-pushed the settimeout-returnthis branch from e914075 to 3f78268 Compare May 14, 2015 14:54

evanlucas changed the title http,net: return this from setTimeout methods http,https,net,tls: return this from setTimeout methods May 14, 2015

silverwind mentioned this pull request May 14, 2015

Returning this in net and its inheriting prototype methods #1657

Closed

silverwind closed this May 16, 2015

This was referenced May 22, 2015

net,dgram: return this from ref and unref methods #1768

Closed

Release proposal v2.1.0 #1777

Closed

net: return this from setNoDelay and setKeepAlive #1779

Closed

MikeRalphson added a commit to MikeRalphson/node that referenced this pull request Aug 31, 2016

Define return type of clientRequest.setTimeout

5dde410

nodejs#1699 did not update documentation

MikeRalphson added a commit to MikeRalphson/node that referenced this pull request Aug 31, 2016

Update return type of clientRequest.setTimeout

e17f070

nodejs#1699 did not update documentation

MikeRalphson mentioned this pull request Aug 31, 2016

Document return type of clientRequest.setTimeout MikeRalphson/node#1

Merged

2 tasks

MikeRalphson mentioned this pull request Aug 31, 2016

doc: add return type of clientRequest.setTimeout #8356

Closed

2 tasks

MikeRalphson added a commit to MikeRalphson/node that referenced this pull request Aug 31, 2016

doc: add return type of clientRequest.setTimeout

ccb0b3d

Refs: nodejs#1699

aliscco mentioned this pull request Dec 2, 2023

[Snyk] Fix for 6 vulnerabilities aliscco/alisco-node#1050

Open

leonardoadame mentioned this pull request Dec 3, 2023

[Snyk] Fix for 1 vulnerabilities leonardoadame/node#477

Open

aliscco mentioned this pull request Dec 3, 2023

[Snyk] Security upgrade @commitlint/cli from 8.2.0 to 9.0.0 aliscco/alisco-node#1104

Open

http,https,net,tls: return this from setTimeout methods by evanlucas · Pull Request #1699 · nodejs/node · GitHub

Uh oh!

Uh oh!

http,https,net,tls: return this from setTimeout methods - #1699

http,https,net,tls: return this from setTimeout methods#1699
evanlucas wants to merge 1 commit into
nodejs:masterfrom
evanlucas:settimeout-returnthis

evanlucas commented May 14, 2015

Uh oh!

brendanashworth commented May 14, 2015

Uh oh!

silverwind commented May 14, 2015

Uh oh!

evanlucas commented May 14, 2015

Uh oh!

evanlucas commented May 14, 2015

Uh oh!

silverwind commented May 16, 2015

Uh oh!

evanlucas commented May 16, 2015

Uh oh!

silverwind commented May 16, 2015

Uh oh!

silverwind commented May 16, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

http,https,net,tls: return this from setTimeout methods by evanlucas · Pull Request #1699 · nodejs/node · GitHub

Uh oh!

Uh oh!

http,https,net,tls: return this from setTimeout methods - #1699

http,https,net,tls: return this from setTimeout methods#1699evanlucas wants to merge 1 commit intonodejs:masternodejs/node:masterfrom evanlucas:settimeout-returnthisevanlucas/node:settimeout-returnthisCopy head branch name to clipboard

Conversation

evanlucas commented May 14, 2015

Uh oh!

brendanashworth commented May 14, 2015

Uh oh!

silverwind commented May 14, 2015

Uh oh!

evanlucas commented May 14, 2015

Uh oh!

evanlucas commented May 14, 2015

Uh oh!

silverwind commented May 16, 2015

Uh oh!

evanlucas commented May 16, 2015

Uh oh!

silverwind commented May 16, 2015

Uh oh!

silverwind commented May 16, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

http,https,net,tls: return this from setTimeout methods#1699
evanlucas wants to merge 1 commit into
nodejs:masterfrom
evanlucas:settimeout-returnthis