FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: correct the wrong added meta data by sabakugaara · Pull Request #17072 · nodejs/node · GitHub

/ node Public

doc: correct the wrong added meta data - #17072

Closed
sabakugaara wants to merge 1 commit into
nodejs:masterfrom
sabakugaara:master
Closed

doc: correct the wrong added meta data#17072
sabakugaara wants to merge 1 commit into
nodejs:masterfrom
sabakugaara:master

Conversation

Copy link
Copy Markdown
Contributor

Fixes: #17026

Checklist
Affected core subsystem(s)

doc

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 16, 2017

MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Doesn't need to wait 48 hours I don't think

Copy link
Copy Markdown
Contributor

landed in 667f8c6

MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
PR-URL: #17072
Fixes: #17026
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

watson commented Nov 24, 2017

Copy link
Copy Markdown
Member

@MylesBorins Currently the default version of the docs still show the wrong version. I'm not sure where the default version of the docs are build from, but if it's the v9.x branch then that still contain the wrong version numbers.

MylesBorins pushed a commit that referenced this pull request Dec 11, 2017
PR-URL: #17072
Fixes: #17026
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins mentioned this pull request Dec 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL