src: use unique_ptr for http2_state - #17078
Closed
fhinkel wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
addaleax
approved these changes
Nov 19, 2017
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
https://ci.nodejs.org/job/node-test-commit-linux/nodes=ubuntu1710-x64/14240/console says: In file included from ../src/inspector_agent.h:13:0,
from ../src/env.h:30,
from ../src/env-inl.h:28,
from ../src/base_object-inl.h:28,
from ../src/async_wrap-inl.h:28,
from ../src/async_wrap.cc:22:
../src/node_platform.h:81:45: error: ‘function’ is not a member of ‘std’
typedef std::unique_ptr<DelayedTask, std::function<void(DelayedTask*)>>
^~~~~~~~
../src/node_platform.h:81:45: note: suggested alternative: ‘is_function’
typedef std::unique_ptr<DelayedTask, std::function<void(DelayedTask*)>>
^~~~~~~~
is_function
../src/node_platform.h:81:45: error: ‘function’ is not a member of ‘std’
../src/node_platform.h:81:45: note: suggested alternative: ‘is_function’
typedef std::unique_ptr<DelayedTask, std::function<void(DelayedTask*)>>
^~~~~~~~
is_function
../src/node_platform.h:81:72: error: template argument 2 is invalid
typedef std::unique_ptr<DelayedTask, std::function<void(DelayedTask*)>>
^~
node.target.mk:202: recipe for target '/home/iojs/build/workspace/node-test-commit-linux/nodes/ubuntu1710-x64/out/Release/obj.target/node/src/async_wrap.o' failed
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thanks for running the CI and spotting the error. Looks like -std=c++0x is missing. I'll look into it. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@fhinkel I’d guess it’s just a missing #include? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
cjihrig
approved these changes
Nov 19, 2017
addaleax
pushed a commit
that referenced
this pull request
Nov 19, 2017
PR-URL: #17078 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17078 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
PR-URL: #17078 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17078 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
src