FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: minor corrections to configure descriptions by danbev · Pull Request #17094 · nodejs/node · GitHub

/ node Public

build: minor corrections to configure descriptions - #17094

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:configure-help-corrections
Closed

build: minor corrections to configure descriptions#17094
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:configure-help-corrections

Conversation

danbev commented Nov 17, 2017

Copy link
Copy Markdown
Contributor

This commit updates --enable-vtune-profiling from:

Enable profiling support for Intel VTune profiler to
profileJavaScript code executed in nodejs.

to:

Enable profiling support for Intel VTune profiler to
profile JavaScript code executed in nodejs.

And --link-module=LINKED_MODULE from:

Path to a JS file to be bundled in the binary as a
builtin.This module will be referenced by path without
extension.e.g. /root/x/y.js will be referenced via

to:

Path to a JS file to be bundled in the binary as a
builtin. This module will be referenced by path
without extension; e.g. /root/x/y.js will be
referenced via require('root/x/y').
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Nov 17, 2017

Copy link
Copy Markdown
Member

FWIW, @vsemozhetbyt identified other corrections to the configure help text in #16975. I'll leave it up to @danbev as to whether to include those here with these changes or to leave for another PR.

Copy link
Copy Markdown
Member

Landed in 6c5a39c

addaleax closed this Nov 18, 2017
addaleax pushed a commit that referenced this pull request Nov 18, 2017
PR-URL: #17094
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17094
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins mentioned this pull request Dec 12, 2017
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17094
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17094
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
gibfahn mentioned this pull request Dec 20, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17094
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
gibfahn mentioned this pull request Dec 20, 2017
MylesBorins mentioned this pull request Dec 20, 2017
danbev deleted the configure-help-corrections branch February 28, 2018 07:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL