FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: introduce categories to Cpp style guide by fhinkel · Pull Request #17095 · nodejs/node · GitHub

/ node Public

doc: introduce categories to Cpp style guide - #17095

Closed
fhinkel wants to merge 1 commit into
nodejs:masterfrom
fhinkel:nov/style-guide-reshuffle
ConversationCommits (1)ChecksFiles changed
Closed

doc: introduce categories to Cpp style guide#17095
fhinkel wants to merge 1 commit into
nodejs:masterfrom
fhinkel:nov/style-guide-reshuffle

Conversation

fhinkel commented Nov 17, 2017

Copy link
Copy Markdown
Contributor

Introduce sections in the Cpp style guide as suggested by @joyeecheung in
#17052 (comment).

Checklist
Affected core subsystem(s)

doc

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 17, 2017
joyeecheung reviewed Nov 17, 2017
View reviewed changes
Comment thread CPP_STYLE_GUIDE.md Outdated

joyeecheung Nov 17, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think this should be ##?

fhinkel Dec 3, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, fixed

Comment thread CPP_STYLE_GUIDE.md Outdated

joyeecheung Nov 17, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you put "Others" as a top level item and put other rules under it?

fhinkel Dec 3, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done

Comment thread CPP_STYLE_GUIDE.md Outdated

joyeecheung Nov 17, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Also should be ##

Comment thread CPP_STYLE_GUIDE.md Outdated

joyeecheung Nov 17, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Same as above

fhinkel Dec 3, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fixed

fhinkel force-pushed the nov/style-guide-reshuffle branch from ae8a2e8 to 1c96975 Compare December 3, 2017 07:57
fhinkel force-pushed the nov/style-guide-reshuffle branch from 1c96975 to afd79ef Compare December 3, 2017 07:59
joyeecheung approved these changes Dec 3, 2017
View reviewed changes

joyeecheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for doing this!

fhinkel commented Dec 3, 2017

Copy link
Copy Markdown
Contributor Author

Landed in fff4272

fhinkel closed this Dec 3, 2017
fhinkel added a commit to fhinkel/node that referenced this pull request Dec 3, 2017
doc: introduce categories to Cpp style guide
fff4272 
Ref: nodejs#17052 (comment)

PR-URL: nodejs#17095
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
doc: introduce categories to Cpp style guide
c556551 
Ref: #17052 (comment)

PR-URL: #17095
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
doc: introduce categories to Cpp style guide
d3e76e7 
Ref: #17052 (comment)

PR-URL: #17095
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
doc: introduce categories to Cpp style guide
073822f 
Ref: #17052 (comment)

PR-URL: #17095
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
doc: introduce categories to Cpp style guide
43215c6 
Ref: #17052 (comment)

PR-URL: #17095
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn mentioned this pull request Dec 20, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cjihrig cjihrig approved these changes
joyeecheung joyeecheung approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL