FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: add missing include in node_platform.h by addaleax · Pull Request #17133 · nodejs/node · GitHub

/ node Public

src: add missing include in node_platform.h - #17133

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:platform-include
ConversationCommits (1)ChecksFiles changed
Closed

src: add missing include in node_platform.h#17133
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:platform-include

Conversation

addaleax commented Nov 19, 2017

Copy link
Copy Markdown
Member

Refs: #17083

I will fast-track this to un-break CI.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src/node_platform

@fhinkel

addaleax added c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. labels Nov 19, 2017
nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 19, 2017

addaleax commented Nov 19, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/14142/

addaleax commented Nov 19, 2017

Copy link
Copy Markdown
Member Author

Landed in d61cd9d

addaleax closed this Nov 19, 2017
addaleax deleted the platform-include branch November 19, 2017 13:21
addaleax added a commit that referenced this pull request Nov 19, 2017
src: add missing include in node_platform.h
d61cd9d 
PR-URL: #17133
Refs: #17083
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

fhinkel commented Nov 19, 2017

Copy link
Copy Markdown
Contributor

Thank you 🙏

MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
src: add missing include in node_platform.h
e900090 
PR-URL: #17133
Refs: #17083
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn mentioned this pull request Dec 19, 2017
Closed
2 tasks

gibfahn commented Jan 27, 2018

Copy link
Copy Markdown
Member

Should come with #17083 if that gets backported to v8.x.

MylesBorins mentioned this pull request May 23, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
apapirovski apapirovski approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL