FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: use better terminology for build machines by addaleax · Pull Request #17142 · nodejs/node · GitHub

/ node Public

doc: use better terminology for build machines - #17142

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:doc-racism
ConversationCommits (1)ChecksFiles changed
Closed

doc: use better terminology for build machines#17142
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:doc-racism

Conversation

addaleax commented Nov 19, 2017

Copy link
Copy Markdown
Member

R=@nodejs/release

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 19, 2017

gireeshpunathil commented Nov 20, 2017

Copy link
Copy Markdown
Member

I remember reviews that discouraged personal pronouns in documents. While none is introduced newly here, there are a few, please have another look and see if this is something you can workaround, while we are here.

gibfahn commented Nov 20, 2017

Copy link
Copy Markdown
Member

While none is introduced newly here, there are a few, please

doc/releases.md is entirely addressed to the releaser, so I'm not sure you is avoidable here. It basically goes through the 100 things a releaser has to do. Changing it would be a pretty substantial rewrite, and probably best done in a separate PR if at all.

As this isn't external documentation, I'm not sure removing you is actually necessary.

vsemozhetbyt commented Nov 20, 2017

Copy link
Copy Markdown
Contributor

FWIW, our STYLE_GUIDE.md notes:

Pronouns are acceptable in more colloquial documentation, like guides.

mhdawson approved these changes Nov 21, 2017
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mhdawson added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 21, 2017

mhdawson commented Nov 21, 2017

Copy link
Copy Markdown
Member

CI run: https://ci.nodejs.org/job/node-test-pull-request/11593/

jasnell pushed a commit that referenced this pull request Nov 22, 2017
doc: use better terminology for build machines
8f50407 
PR-URL: #17142
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

jasnell commented Nov 22, 2017

Copy link
Copy Markdown
Member

Landed in 8f50407

jasnell closed this Nov 22, 2017

Trott commented Nov 23, 2017

Copy link
Copy Markdown
Member

There's one more instance in a comment in tools/release.sh if someone wants to fix that one or maybe hand it out as a good first task to someone.

addaleax removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 28, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
doc: use better terminology for build machines
9528fa1 
PR-URL: #17142
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
doc: use better terminology for build machines
1a3aadb 
PR-URL: #17142
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
doc: use better terminology for build machines
8441632 
PR-URL: #17142
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
doc: use better terminology for build machines
5f522a1 
PR-URL: #17142
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
doc: use better terminology for build machines
eb041a0 
PR-URL: #17142
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gibfahn mentioned this pull request Dec 20, 2017
Merged
MylesBorins mentioned this pull request Dec 20, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
gireeshpunathil gireeshpunathil approved these changes
+5 more reviewers
apapirovski apapirovski approved these changes
refack refack approved these changes
mhdawson mhdawson approved these changes
vsemozhetbyt vsemozhetbyt approved these changes
gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL