stream: improve the error message of ERR_INVALID_ARG_TYPE - #17145
stream: improve the error message of ERR_INVALID_ARG_TYPE#17145starkwang wants to merge 1 commit into
Conversation
Sorry, something went wrong.
The `expected` argument of `ERR_INVALID_ARG_TYPE` can be an array, which is better than a single string.
Sorry, something went wrong.
joyeecheung
left a comment
There was a problem hiding this comment.
This does not need 48-hours. LGTM once CI is green
Sorry, something went wrong.
The `expected` argument of `ERR_INVALID_ARG_TYPE` can be an array, which is better than a single string. PR-URL: #17145 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
The `expected` argument of `ERR_INVALID_ARG_TYPE` can be an array, which is better than a single string. PR-URL: #17145 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
The `expected` argument of `ERR_INVALID_ARG_TYPE` can be an array, which is better than a single string. PR-URL: #17145 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
|
Should this have been semver-major? I thought we were not landing error changes as semver-patch until the entire system was updated My apologies if I am mistaken. Please adjust lts labels as appropriate |
Sorry, something went wrong.
|
@MylesBorins The error message prior to the changed one was Invalid non-string/buffer chunk, then it's migrated in v9.x to something like The "chunk" argument must be of type string/Buffer/Uint8Array. Received type null, this PR just changes that again to The "chunk" argument must be one of type string, Buffer, or Uint8Array. Received type null. The error code is untouched so I think it's reasonable to backport this to 9.x. |
Sorry, something went wrong.
The expected argument of ERR_INVALID_ARG_TYPE can be an array, which is better than a single string.
Checklist
Affected core subsystem(s)
stream