FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: remove unused variable by cjihrig · Pull Request #17150 · nodejs/node · GitHub

/ node Public

src: remove unused variable - #17150

Closed
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:unused-var
Closed

src: remove unused variable#17150
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:unused-var

Conversation

cjihrig commented Nov 20, 2017

Copy link
Copy Markdown
Contributor

This fixes a compiler warning.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

This fixes a compiler warning.
nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 20, 2017

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-commit/14172/

I think this is trivial enough to not have to wait 48 hours.

Copy link
Copy Markdown
Member

Landed in 5df0b9e

addaleax closed this Nov 21, 2017
addaleax pushed a commit that referenced this pull request Nov 21, 2017
This fixes a compiler warning.

PR-URL: #17150
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
cjihrig deleted the unused-var branch November 21, 2017 13:34
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
This fixes a compiler warning.

PR-URL: #17150
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Dec 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants


Back | FazBrowse Home | New Git URL