FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

get rid of more not-nice terms by devsnek · Pull Request #17170 · nodejs/node · GitHub

/ node Public

get rid of more not-nice terms - #17170

Closed
devsnek wants to merge 2 commits into
nodejs:masterfrom
devsnek:words
ConversationCommits (2)ChecksFiles changed
Closed

get rid of more not-nice terms#17170
devsnek wants to merge 2 commits into
nodejs:masterfrom
devsnek:words

Conversation

devsnek commented Nov 21, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

this was all i could find with ack and a bunch of not nice phrases and words

Checklist
Affected core subsystem(s)

nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 21, 2017
aqrln approved these changes Nov 21, 2017
View reviewed changes
Comment thread test/parallel/test-process-raw-debug.js Outdated

aqrln Nov 21, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nit: maybe use a colon here?

davisjam Nov 21, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Agreed, colon will yield a cleaner message

mscdex added child_process Issues and PRs related to the child_process subsystem. process Issues and PRs related to the process subsystem. repl Issues and PRs related to the REPL subsystem. net Issues and PRs related to the net subsystem. labels Nov 21, 2017
apapirovski approved these changes Nov 21, 2017
View reviewed changes

apapirovski left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with the nit from @aqrln fixed, also the commit message would ideally be updated to something like test: clean up inappropriate language or something.

devsnek force-pushed the words branch 2 times, most recently from fff8773 to 6e9b431 Compare November 21, 2017 14:40
aqrln reviewed Nov 21, 2017
View reviewed changes
Comment thread test/parallel/test-process-raw-debug.js Outdated
return parent();
default:
throw new Error(`wtf? ${process.argv[2]}`);
throw new Error(`invalid; ${process.argv[2]}`);

aqrln Nov 21, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry for being pedantic, but this is a semicolon, not a colon (:) 😄

mhdawson approved these changes Nov 21, 2017
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jasnell commented Nov 21, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11592/

joyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 21, 2017

joyeecheung commented Nov 21, 2017

Copy link
Copy Markdown
Member

Added fast-track although there are already a ton of approvals.

joyeecheung added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 21, 2017

aqrln commented Nov 22, 2017

Copy link
Copy Markdown
Contributor

+1 to fast-tracking. I went ahead and fixed the nit myself. Gonna land it after the CI finishes green.

New CI: https://ci.nodejs.org/job/node-test-pull-request/11623/

aqrln commented Nov 22, 2017

Copy link
Copy Markdown
Contributor

Landed in 7fd8a21.

aqrln closed this Nov 22, 2017
aqrln pushed a commit that referenced this pull request Nov 22, 2017
test: clean up inappropriate language
7fd8a21 
PR-URL: #17170
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
aqrln removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 22, 2017
devsnek deleted the words branch November 22, 2017 15:05
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: clean up inappropriate language
c64d1cd 
PR-URL: #17170
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: clean up inappropriate language
72e480d 
PR-URL: #17170
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins mentioned this pull request Dec 12, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
test: clean up inappropriate language
0963c75 
PR-URL: #17170
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
test: clean up inappropriate language
861082a 
PR-URL: #17170
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
test: clean up inappropriate language
bd8d7d7 
PR-URL: #17170
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gibfahn mentioned this pull request Dec 20, 2017
Merged
MylesBorins mentioned this pull request Dec 20, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
gireeshpunathil gireeshpunathil approved these changes
+8 more reviewers
aqrln aqrln approved these changes
davisjam davisjam left review comments
apapirovski apapirovski approved these changes
fhinkel fhinkel approved these changes
danbev danbev approved these changes
TimothyGu TimothyGu approved these changes
targos targos approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

child_process Issues and PRs related to the child_process subsystem. fast-track PRs that do not need to wait for 48 hours to land. net Issues and PRs related to the net subsystem. process Issues and PRs related to the process subsystem. repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL