src: make base64.h self-contained - #17177
Closed
danbev wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This commit includes stdint.h (for uint8_t, uint32_t, and int8_t) to make it self-contained.
addaleax
approved these changes
Nov 21, 2017
Copy link
Copy Markdown
Member
|
I am sorry, but unable to follow - by including a new header (that carry some types required in the file which were resolved otherwise through different route) what benefit we foresee to the compilation unit? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
One benefit is that making changes to util.h will not affect base64.h, so the types that are used by this header are also included by it. Google's C++ Style Guide has some more details plus I recall this being brought up on previous pull requests I've made where I missed this. |
Sorry, something went wrong.
gireeshpunathil
approved these changes
Nov 21, 2017
cjihrig
approved these changes
Nov 21, 2017
jasnell
approved these changes
Nov 21, 2017
aqrln
approved these changes
Nov 21, 2017
TimothyGu
approved these changes
Nov 21, 2017
danbev
added a commit
that referenced
this pull request
Nov 27, 2017
This commit includes stdint.h (for uint8_t, uint32_t, and int8_t) to make it self-contained. PR-URL: #17177 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
This commit includes stdint.h (for uint8_t, uint32_t, and int8_t) to make it self-contained. PR-URL: #17177 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
This commit includes stdint.h (for uint8_t, uint32_t, and int8_t) to make it self-contained. PR-URL: #17177 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
This commit includes stdint.h (for uint8_t, uint32_t, and int8_t) to make it self-contained. PR-URL: #17177 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
This commit includes stdint.h (for uint8_t, uint32_t, and int8_t) to make it self-contained. PR-URL: #17177 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
This commit includes stdint.h (for uint8_t, uint32_t, and int8_t) to make it self-contained. PR-URL: #17177 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
This commit includes stdint.h (for uint8_t, uint32_t, and int8_t) to make it self-contained. PR-URL: #17177 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit includes stdint.h (for uint8_t, uint32_t, and int8_t) to
make it self-contained.
Checklist
Affected core subsystem(s)
src