FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: use common.crashOnUnhandledRejection by sj82516 · Pull Request #17215 · nodejs/node · GitHub

/ node Public

test: use common.crashOnUnhandledRejection - #17215

Closed
sj82516 wants to merge 1 commit into
nodejs:masterfrom
sj82516:my-first-pr-to-node
ConversationCommits (1)ChecksFiles changed
Closed

test: use common.crashOnUnhandledRejection#17215
sj82516 wants to merge 1 commit into
nodejs:masterfrom
sj82516:my-first-pr-to-node

Conversation

sj82516 commented Nov 22, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add common.crashOnUnhandledRejection to test/parallel/test-microtask-queue-integration-domain.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 22, 2017
MylesBorins approved these changes Nov 22, 2017
View reviewed changes

MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

MylesBorins commented Nov 22, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/11613/

danbev approved these changes Nov 22, 2017
View reviewed changes
Comment thread test/parallel/test-microtask-queue-integration-domain.js Outdated

danbev Nov 22, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think common needs to be declared first:

const common = require('../common');

MylesBorins added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 22, 2017

gireeshpunathil commented Nov 22, 2017

Copy link
Copy Markdown
Member

@sj82516 - your second commit brought about 94 files - accidental?

sj82516 commented Nov 22, 2017

Copy link
Copy Markdown
Contributor Author

I run make -j4 test for test and then it installed the node modules.
I will remove the unnecessary part.
Sorry about that

mscdex commented Nov 22, 2017

Copy link
Copy Markdown
Contributor

It seems a bunch of pre-existing node modules are now being removed?

mscdex added domain Issues and PRs related to the domain subsystem. process Issues and PRs related to the process subsystem. v8 engine Issues and PRs related to the V8 dependency. labels Nov 22, 2017

sj82516 commented Nov 22, 2017

Copy link
Copy Markdown
Contributor Author

yes, I removed them.
Sorry for the accident

jasnell previously approved these changes Nov 22, 2017
View reviewed changes
jasnell dismissed their stale review November 22, 2017 16:15

Removing my sign off until the extraneous commits can be cleaned up

jasnell requested changes Nov 22, 2017
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This PR will need to be reworked to remove the extraneous edits

sj82516 force-pushed the my-first-pr-to-node branch from 1487903 to 449be86 Compare November 23, 2017 01:23

sj82516 commented Nov 23, 2017

Copy link
Copy Markdown
Contributor Author

I rebase the commit and push force again.
Is that correct now ?
Sorry for the first time PR to the nodejs project.

mscdex commented Nov 23, 2017

Copy link
Copy Markdown
Contributor

Still the same problem. I think you will need to edit your commit since it seems the file removals are a part of the same commit as your actual (test) changes.

remove extra instructions.
d47c150 
reset the commit to remvoe extra instructions.

sj82516 commented Nov 23, 2017

Copy link
Copy Markdown
Contributor Author

I see.
So I would reset and rewrite the commit.
Should I push force to this PR or cancel this PR and create new one ?

MylesBorins commented Nov 23, 2017

Copy link
Copy Markdown
Contributor

@sj82516 you can always force push over the branch you made the PR with

sj82516 force-pushed the my-first-pr-to-node branch from 449be86 to d47c150 Compare November 23, 2017 02:46

mscdex commented Nov 23, 2017

Copy link
Copy Markdown
Contributor

Looks better now.

targos commented Nov 23, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11671/

MylesBorins pushed a commit that referenced this pull request Nov 26, 2017
test: use common.crashOnUnhandledRejection
7518617 
PR-URL: #17215
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins commented Nov 26, 2017

Copy link
Copy Markdown
Contributor

landed in 7518617 with some minor nits addressed

MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: use common.crashOnUnhandledRejection
72a7147 
PR-URL: #17215
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: use common.crashOnUnhandledRejection
c375816 
PR-URL: #17215
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
test: use common.crashOnUnhandledRejection
e73c191 
PR-URL: #17215
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
test: use common.crashOnUnhandledRejection
b63f51a 
PR-URL: #17215
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
test: use common.crashOnUnhandledRejection
e07c200 
PR-URL: #17215
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
gibfahn mentioned this pull request Dec 20, 2017
Merged
MylesBorins mentioned this pull request Dec 20, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell requested changes
+3 more reviewers
danbev danbev approved these changes
MylesBorins MylesBorins approved these changes
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. domain Issues and PRs related to the domain subsystem. process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL