test: use crashOnUnhandledRejection - #17220
Closed
imZack wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Add common.crashOnUnhandledRejection to test/parallel/test-async-hooks-disable-during-promise.js
MylesBorins
approved these changes
Nov 22, 2017
MylesBorins
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
gireeshpunathil
approved these changes
Nov 22, 2017
cjihrig
approved these changes
Nov 22, 2017
jasnell
approved these changes
Nov 22, 2017
Copy link
Copy Markdown
Member
|
One failure in CI is unrelated. |
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
Nov 22, 2017
Add common.crashOnUnhandledRejection to test/parallel/test-async-hooks-disable-during-promise.js PR-URL: #17220 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Member
|
Landed in 5d6693f! Thank you and congrats on your PR to core! |
Sorry, something went wrong.
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Add common.crashOnUnhandledRejection to test/parallel/test-async-hooks-disable-during-promise.js PR-URL: #17220 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Add common.crashOnUnhandledRejection to test/parallel/test-async-hooks-disable-during-promise.js PR-URL: #17220 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
Add common.crashOnUnhandledRejection to test/parallel/test-async-hooks-disable-during-promise.js PR-URL: #17220 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Add common.crashOnUnhandledRejection to test/parallel/test-async-hooks-disable-during-promise.js PR-URL: #17220 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add common.crashOnUnhandledRejection right after main require statements
Checklist
Affected core subsystem(s)
test