test: add common.crashOnUnhandledRejection() to test-http2-window-size.js - #17227
Closed
IvanWei wants to merge 1 commit into
Closed
test: add common.crashOnUnhandledRejection() to test-http2-window-size.js#17227IvanWei wants to merge 1 commit into
IvanWei wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
hey @IvanWei generally we would want these two changes to come in two different pull requests. Would you be able to move the eslint changes to a new PR? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Hey @MylesBorins Oh! I'm able to move the eslint changes to new PR. |
Sorry, something went wrong.
MylesBorins
approved these changes
Nov 22, 2017
MylesBorins
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
gireeshpunathil
approved these changes
Nov 22, 2017
Copy link
Copy Markdown
Member
Sorry, something went wrong.
jasnell
approved these changes
Nov 22, 2017
jasnell
pushed a commit
that referenced
this pull request
Nov 22, 2017
add common.crashOnUnhandledRejectio to test-http2-window-size.js PR-URL: #17227 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Member
|
Landed in a3a987b! Thank you and congrats on your PR to core! |
Sorry, something went wrong.
2 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
add common.crashOnUnhandledRejectio to test-http2-window-size.js PR-URL: #17227 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
add common.crashOnUnhandledRejectio to test-http2-window-size.js PR-URL: #17227 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
add common.crashOnUnhandledRejectio to test-http2-window-size.js PR-URL: #17227 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
add common.crashOnUnhandledRejectio to test-http2-window-size.js PR-URL: #17227 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)