FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: add crashOnUnhandledRejection by DanielLin9406 · Pull Request #17237 · nodejs/node · GitHub

/ node Public

test: add crashOnUnhandledRejection - #17237

Closed
DanielLin9406 wants to merge 1 commit into
nodejs:masterfrom
DanielLin9406:nodefork
ConversationCommits (1)ChecksFiles changed
Closed

test: add crashOnUnhandledRejection#17237
DanielLin9406 wants to merge 1 commit into
nodejs:masterfrom
DanielLin9406:nodefork

Conversation

DanielLin9406 commented Nov 22, 2017 •
edited
Loading

Copy link
Copy Markdown
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 22, 2017
DanielLin9406 changed the title add crashOnUnhandledRejection test: add crashOnUnhandledRejection Nov 22, 2017

gireeshpunathil commented Nov 22, 2017

Copy link
Copy Markdown
Member

@DanielLin9406 your email id is not associated with this commit (github will fail to highlight you as a contributor). Please update
git config --global user.email and commit again.

MylesBorins previously requested changes Nov 22, 2017
View reviewed changes

MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you please squash your two commits and update the commit message to

test: add crashonUnhandledRejection

Comment thread test/sequential/test-inspector-port-cluster.js Outdated

MylesBorins Nov 22, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this line should not be removed

gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 22, 2017
mscdex added the inspector Issues and PRs related to the V8 inspector protocol label Nov 22, 2017
jasnell dismissed MylesBorins’s stale review November 22, 2017 20:02

Comment addressed

jasnell commented Nov 22, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11641/

jasnell pushed a commit that referenced this pull request Nov 22, 2017
test: add crashonUnhandledRejection
3f19ecd 
PR-URL: #17237
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Nov 22, 2017

Copy link
Copy Markdown
Member

Landed in 3f19ecd. thank you! and congrats on your PR to core!

jasnell closed this Nov 22, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: add crashonUnhandledRejection
611a42e 
PR-URL: #17237
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: add crashonUnhandledRejection
ce284fc 
PR-URL: #17237
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
test: add crashonUnhandledRejection
eb1f8c5 
PR-URL: #17237
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
test: add crashonUnhandledRejection
0daf33e 
PR-URL: #17237
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn mentioned this pull request Dec 20, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
gireeshpunathil gireeshpunathil approved these changes
+1 more reviewer
MylesBorins MylesBorins left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL