FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: Update HTTP -> HTTPS in README.md by him2him2 · Pull Request #17264 · nodejs/node · GitHub

/ node Public

doc: Update HTTP -> HTTPS in README.md - #17264

Closed
him2him2 wants to merge 1 commit into
nodejs:masterfrom
him2him2:_fix_README.md_HTTPS
Closed

doc: Update HTTP -> HTTPS in README.md#17264
him2him2 wants to merge 1 commit into
nodejs:masterfrom
him2him2:_fix_README.md_HTTPS

Conversation

Copy link
Copy Markdown
Contributor

URLs were updated to use HTTPS protocol in README.md.

Checklist
Affected core subsystem(s)

doc

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 22, 2017

Copy link
Copy Markdown
Contributor

can you please include the subsystem in the commit message and
doc: Update HTTP -> HTTPS in...

Also, in future you can likely make a single PR when a group of changes are similar like this

Thank you for taking the time to update this!

MylesBorins left a comment
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with Nit

Shouldn't have to wait 48 hours

MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 23, 2017
him2him2 changed the title Update HTTP -> HTTPS in README.md doc: Update HTTP -> HTTPS in README.md Nov 23, 2017
URLs were updated to use HTTPS protocol in README.md.
him2him2 force-pushed the _fix_README.md_HTTPS branch from a4d6d37 to 4e2432a Compare November 23, 2017 05:17

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Contributor

Landed in 0028241

apapirovski pushed a commit that referenced this pull request Nov 23, 2017
PR-URL: #17264
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
him2him2 deleted the _fix_README.md_HTTPS branch November 24, 2017 06:16
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17264
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17264
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins mentioned this pull request Dec 12, 2017
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17264
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17264
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
gibfahn mentioned this pull request Dec 20, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17264
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
gibfahn mentioned this pull request Dec 20, 2017
MylesBorins mentioned this pull request Dec 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL