FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: typo in api doc of url.format(urlObject) by pdkovacs · Pull Request #17295 · nodejs/node · GitHub

/ node Public

doc: typo in api doc of url.format(urlObject) - #17295

Closed
pdkovacs wants to merge 1 commit into
nodejs:masterfrom
pdkovacs:17294-copy-paste-typo
ConversationCommits (1)ChecksFiles changed
Closed

doc: typo in api doc of url.format(urlObject)#17295
pdkovacs wants to merge 1 commit into
nodejs:masterfrom
pdkovacs:17294-copy-paste-typo

Conversation

pdkovacs commented Nov 25, 2017

Copy link
Copy Markdown

Fixes #17294

Checklist
Affected core subsystem(s)

doc

nodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Nov 25, 2017
vsemozhetbyt approved these changes Nov 25, 2017
View reviewed changes

vsemozhetbyt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you!

vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 25, 2017

vsemozhetbyt commented Nov 25, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/11702/

evanlucas approved these changes Nov 25, 2017
View reviewed changes

evanlucas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Thanks for the contribution!

vsemozhetbyt commented Nov 25, 2017

Copy link
Copy Markdown
Contributor

CI failures seem doc-unrelated. Landing...

vsemozhetbyt commented Nov 25, 2017

Copy link
Copy Markdown
Contributor

Landed in 29423b4

Thank you, @pdkovacs!

vsemozhetbyt pushed a commit that referenced this pull request Nov 25, 2017
doc: fix typo in api doc of url.format(urlObject)
29423b4 
PR-URL: #17295
Fixes: #17294
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
vsemozhetbyt mentioned this pull request Nov 25, 2017
Closed
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
doc: fix typo in api doc of url.format(urlObject)
0df88ce 
PR-URL: #17295
Fixes: #17294
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
doc: fix typo in api doc of url.format(urlObject)
524db29 
PR-URL: #17295
Fixes: #17294
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
doc: fix typo in api doc of url.format(urlObject)
10bf570 
PR-URL: #17295
Fixes: #17294
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
doc: fix typo in api doc of url.format(urlObject)
46dc241 
PR-URL: #17295
Fixes: #17294
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
doc: fix typo in api doc of url.format(urlObject)
ceab928 
PR-URL: #17295
Fixes: #17294
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
gibfahn mentioned this pull request Dec 20, 2017
Merged
MylesBorins mentioned this pull request Dec 20, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
gireeshpunathil gireeshpunathil approved these changes
+3 more reviewers
apapirovski apapirovski approved these changes
evanlucas evanlucas approved these changes
vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. url Issues and PRs related to the legacy built-in url module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Copy-paste typo in the API doc of url.format(urlObject).

9 participants

Back | FazBrowse Home | New Git URL