FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: mock dns lookup function in parallel tests by joyeecheung · Pull Request #17296 · nodejs/node · GitHub

/ node Public

test: mock dns lookup function in parallel tests - #17296

Closed
joyeecheung wants to merge 2 commits into
nodejs:masterfrom
joyeecheung:mock-lookup
ConversationCommits (2)ChecksFiles changed
Closed

test: mock dns lookup function in parallel tests#17296
joyeecheung wants to merge 2 commits into
nodejs:masterfrom
joyeecheung:mock-lookup

Conversation

joyeecheung commented Nov 25, 2017 •
edited
Loading

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

These tests should not make any DNS calls. The lookup would fail when the DNS requests are hijacked and time out instead of erroring out.

Refs: nodejs/help#687
Refs: #14781 (comment)

test: add common.dns.errorLookupMock
452c4b8
test: mock the lookup function in parallel tests
a5403ec 
These tests should not make any DNS calls. The lookup would fail
when the DNS requests are hijacked and time out instead of erroring
out.
nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 25, 2017

joyeecheung commented Nov 25, 2017 •
edited
Loading

Copy link
Copy Markdown
Member Author

These failures happened to me again when I was on the hotel wifi. We should just mock the requests.

cc @refack @Trott

joyeecheung commented Nov 25, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/11704/

refack added the dns Issues and PRs related to the dns subsystem. label Nov 25, 2017

refack commented Nov 25, 2017

Copy link
Copy Markdown
Contributor

These tests should not make any DNS calls.

I totally agree with that.
The proposed implementation, I need to think about... (D.R.Y. is a non-goal in tests IMO)

Trott commented Nov 25, 2017

Copy link
Copy Markdown
Member

The proposed implementation, I need to think about... (D.R.Y. is a non-goal in tests IMO)

Generally agree, but I'm 👍 on mocks/test doubles being D.R.Y.

Trott approved these changes Nov 25, 2017
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. If it's easy/quick enough to do, it might be worth comparing a coverage run with and without these changes to see if this loses anything in terms of coverage of the lib/dns.js code.

joyeecheung commented Nov 26, 2017

Copy link
Copy Markdown
Member Author

@Trott I think if the coverage decreases we would need to write other tests for that (or it would be ideal if we can run the internet tests on the coverage machine & a testing CI job).

joyeecheung commented Nov 26, 2017

Copy link
Copy Markdown
Member Author

node-test-commit-linux-linked failed but didn't look related...trying a new one: https://ci.nodejs.org/job/node-test-commit-linux-linked/374/

joyeecheung added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 26, 2017
joyeecheung added a commit that referenced this pull request Nov 28, 2017
test: add common.dns.errorLookupMock
59ed40a 
PR-URL: #17296
Refs: nodejs/help#687
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung added a commit that referenced this pull request Nov 28, 2017
test: mock the lookup function in parallel tests
0fb1e07 
These tests should not make any DNS calls. The lookup would fail
when the DNS requests are hijacked and time out instead of erroring
out.

PR-URL: #17296
Refs: nodejs/help#687
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

joyeecheung commented Nov 28, 2017

Copy link
Copy Markdown
Member Author

Landed in 59ed40a and 0fb1e07, thanks!

TimothyGu removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 29, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: add common.dns.errorLookupMock
7144544 
PR-URL: #17296
Refs: nodejs/help#687
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: mock the lookup function in parallel tests
28a96ab 
These tests should not make any DNS calls. The lookup would fail
when the DNS requests are hijacked and time out instead of erroring
out.

PR-URL: #17296
Refs: nodejs/help#687
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: add common.dns.errorLookupMock
b7578bf 
PR-URL: #17296
Refs: nodejs/help#687
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: mock the lookup function in parallel tests
e2ae99f 
These tests should not make any DNS calls. The lookup would fail
when the DNS requests are hijacked and time out instead of erroring
out.

PR-URL: #17296
Refs: nodejs/help#687
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: add common.dns.errorLookupMock
4e789a3 
PR-URL: #17296
Refs: nodejs/help#687
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: mock the lookup function in parallel tests
3d45a94 
These tests should not make any DNS calls. The lookup would fail
when the DNS requests are hijacked and time out instead of erroring
out.

PR-URL: #17296
Refs: nodejs/help#687
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Dec 12, 2017
Merged

gibfahn commented Dec 19, 2017

Copy link
Copy Markdown
Member

Should this be backported to v6/v8.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

gibfahn mentioned this pull request Dec 20, 2017
Closed
2 tasks
joyeecheung mentioned this pull request Mar 30, 2018
Closed
joyeecheung added a commit to joyeecheung/node that referenced this pull request Mar 30, 2018
test: add common.dns.errorLookupMock
fde95ff 
PR-URL: nodejs#17296
Refs: nodejs/help#687
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung added a commit to joyeecheung/node that referenced this pull request Mar 30, 2018
test: mock the lookup function in parallel tests
d989b20 
These tests should not make any DNS calls. The lookup would fail
when the DNS requests are hijacked and time out instead of erroring
out.

PR-URL: nodejs#17296
Refs: nodejs/help#687
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit that referenced this pull request Apr 11, 2018
test: add common.dns.errorLookupMock
34af494 
PR-URL: #17296
Backport-PR-URL: #19706
Refs: nodejs/help#687
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit that referenced this pull request Apr 11, 2018
test: mock the lookup function in parallel tests
da16227 
These tests should not make any DNS calls. The lookup would fail
when the DNS requests are hijacked and time out instead of erroring
out.

PR-URL: #17296
Backport-PR-URL: #19706
Refs: nodejs/help#687
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request May 2, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
+1 more reviewer
refack refack approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dns Issues and PRs related to the dns subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL