FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: add a `make help` option for common targets by gibfahn · Pull Request #17323 · nodejs/node · GitHub

/ node Public

build: add a make help option for common targets - #17323

Merged
gibfahn merged 1 commit into
nodejs:masterfrom
gibfahn:make-help
Dec 9, 2017
ConversationCommits (1)ChecksFiles changed
Merged

build: add a make help option for common targets#17323
gibfahn merged 1 commit into
nodejs:masterfrom
gibfahn:make-help

Conversation

gibfahn commented Nov 26, 2017

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

The Makefile has quite a large number of targets, so I only added the ones that I thought people would most need to know about.

Output:

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Nov 26, 2017
maclover7 approved these changes Nov 26, 2017
View reviewed changes

maclover7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

One comment, otherwise LGTM

Comment thread Makefile Outdated

maclover7 Nov 26, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

build docs --> builds docs?

gibfahn Nov 26, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fixed.

bnoordhuis approved these changes Nov 26, 2017
View reviewed changes

bnoordhuis left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM but cc @joyeecheung, this PR overlaps to some extent with #16975.

(edit: nevermind, just saw this PR is in response to that PR.)

Comment thread Makefile Outdated

bnoordhuis Nov 26, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you add a line break to keep it < 81 columns?

gibfahn Nov 26, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sure.

gibfahn commented Nov 26, 2017

Copy link
Copy Markdown
Member Author

LGTM but cc @joyeecheung, this PR overlaps to some extent with #16975.

(edit: nevermind, just saw this PR is in response to that PR.)

Yep, this is meant to complement that PR, so would definitely appreciate a review from @joyeecheung !

addaleax approved these changes Nov 27, 2017
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I really like this.

gibfahn commented Nov 27, 2017

Copy link
Copy Markdown
Member Author

Might be too much of a change, but just for info, the alacritty Makefile I got the idea from sets help as the default command, so if you do make it runs make help. Something for a future PR maybe.

https://github.com/jwilm/alacritty/blob/8ff3c5d170abe47554f5d2a41ad35ddc451d254d/Makefile#L18

richardlau commented Nov 27, 2017

Copy link
Copy Markdown
Member

Doesn't make default to the first target?

gibfahn commented Nov 27, 2017

Copy link
Copy Markdown
Member Author

@richardlau good point, yes it does, should have rechecked after moving it up to the top.

I've moved it down to below. TBH I think having it be the default makes sense, but I'd rather get this landed so people can start using it, and have that discussion afterwards.

evanlucas reviewed Nov 27, 2017
View reviewed changes
Comment thread Makefile Outdated

evanlucas Nov 27, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

should this be removed or just moved down to the next line?

joyeecheung Nov 28, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes..why are we removing this?

gibfahn Nov 28, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

My bad, I made it an inline comment, then decided the help was getting too long and removed it again. Fixed.

refack commented Nov 27, 2017

Copy link
Copy Markdown
Contributor

Is the ## trick documented anywhere?

joyeecheung approved these changes Nov 28, 2017
View reviewed changes

joyeecheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM minus a question about removing coverage-clean comments

Comment thread Makefile Outdated

joyeecheung Nov 28, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes..why are we removing this?

gibfahn force-pushed the make-help branch 2 times, most recently from fba663c to ab388f1 Compare November 28, 2017 12:08

gibfahn commented Nov 28, 2017

Copy link
Copy Markdown
Member Author

Is the ## trick documented anywhere?

Added a line to explain.

richardlau approved these changes Nov 28, 2017
View reviewed changes

richardlau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

New target help should be phony but otherwise LGTM.

gibfahn commented Nov 29, 2017

Copy link
Copy Markdown
Member Author

New target help should be phony but otherwise LGTM.

Done

apapirovski commented Dec 8, 2017

Copy link
Copy Markdown
Contributor

ping @gibfahn — does this need anything else to land?

CI: https://ci.nodejs.org/job/node-test-pull-request/11989/

build: add a make help option for common targets
d865395 
PR-URL: nodejs#17323
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
gibfahn merged commit d865395 into nodejs:master Dec 9, 2017
gibfahn deleted the make-help branch December 9, 2017 08:11
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
build: add a make help option for common targets
3b27948 
PR-URL: #17323
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
build: add a make help option for common targets
4bb27a2 
PR-URL: #17323
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn self-assigned this Dec 20, 2017
gibfahn added a commit that referenced this pull request Dec 20, 2017
build: add a make help option for common targets
58a667c 
PR-URL: #17323
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
gibfahn mentioned this pull request Dec 20, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes
jasnell jasnell approved these changes
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
joyeecheung joyeecheung approved these changes
richardlau richardlau approved these changes
+3 more reviewers
refack refack approved these changes
evanlucas evanlucas approved these changes
maclover7 maclover7 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

gibfahn

Labels

build Issues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL