refactor: test cases in test-http-status-reason-invalid-chars to use countdown - #17342
Closed
mithunsasidharan wants to merge 1 commit into
Closed
refactor: test cases in test-http-status-reason-invalid-chars to use countdown#17342mithunsasidharan wants to merge 1 commit into
mithunsasidharan wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
daxlab
approved these changes
Nov 27, 2017
maclover7
approved these changes
Nov 27, 2017
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@apapirovski : Can you please run the CI for this too ? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@mithunsasidharan looks like there's a CI from before that came back green other than known failures. This should be ready to land whenever someone gets a chance. |
Sorry, something went wrong.
apapirovski
approved these changes
Dec 3, 2017
Copy link
Copy Markdown
Contributor
|
Landing... |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thank you for your contribution, landed in 2afd4e7. |
Sorry, something went wrong.
maclover7
pushed a commit
that referenced
this pull request
Dec 3, 2017
PR-URL: #17342 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17342 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17342 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17342 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17342 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17342 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 more reviewersAssignees
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored test-http-status-reason-invalid-chars file to use countdown as per issue #17169
Checklist
Affected core subsystem(s)
test