test: update test/parallel/test-http-pipe-fs.js to use countdown - #17346
Closed
chungngoops wants to merge 2 commits into
Closed
test: update test/parallel/test-http-pipe-fs.js to use countdown#17346chungngoops wants to merge 2 commits into
chungngoops wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
maclover7
approved these changes
Nov 27, 2017
addaleax
approved these changes
Nov 27, 2017
Comment thread
test/parallel/test-http-pipe-fs.js
Outdated
|
|
||
| for (let i = 0; i < 2; ++i) { | ||
| for (let i = 0; i < NUMBER_OF_STREAMS; ++i) { | ||
| (function(i) { |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I think this entire closure might be unnecessary now, because the countdown removes the only use of i that was not for debugging?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
@addaleax I just push a new commit that removes the unnecessary IIFE.
Sorry, something went wrong.
addaleax
approved these changes
Nov 27, 2017
addaleax
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks, looks good!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Landed in fa07249 Thanks for the PR! 🎉 ✨ |
Sorry, something went wrong.
addaleax
pushed a commit
that referenced
this pull request
Dec 1, 2017
PR-URL: #17346 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17346 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17346 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17346 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anna Henningsen <anna@addaleax.net>
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17346 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17346 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Refactor the test case test/parallel/test-http-pipe-fs.js to use countdown, as issues #17169
Checklist
Affected core subsystem(s)
test