tools: add docs for prefer-util-format-errors rule - #17376
Conversation
Sorry, something went wrong.
I had a little trouble understanding what the rule was trying to say, so am documenting what would pass/fail.
Trott
left a comment
There was a problem hiding this comment.
LGTM. One possible minor improvements if you feel so inclined: Show what the failing example could be rewritten as and (if it's not immediately obvious) an explanation of why it's better than the failing code.
Sorry, something went wrong.
gibfahn
left a comment
There was a problem hiding this comment.
Very helpful, thanks!
Sorry, something went wrong.
mhdawson
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
|
Just an FYI, the tests for these lint rules can also often be used as supplementary information. For this rule: https://github.com/nodejs/node/blob/master/test/parallel/test-eslint-prefer-util-format-errors.js |
Sorry, something went wrong.
|
CI looks to be passing: https://ci.nodejs.org/job/node-test-commit/14481/, landing... |
Sorry, something went wrong.
I had a little trouble understanding what the rule was trying to say, so am documenting what would pass/fail. PR-URL: #17376 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
I had a little trouble understanding what the rule was trying to say, so am documenting what would pass/fail. PR-URL: #17376 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
I had a little trouble understanding what the rule was trying to say, so
am documenting what would pass/fail.
Checklist
Affected core subsystem(s)
tools