doc: examples for fast-tracking regression fixes - #17379
Closed
refack wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
2 tasks
targos
approved these changes
Nov 29, 2017
targos
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks
Sorry, something went wrong.
joyeecheung
approved these changes
Nov 29, 2017
gibfahn
reviewed
Nov 29, 2017
Comment thread
COLLABORATOR_GUIDE.md
|
|
||
| * Focused changes that affect only documentation and/or the test suite: | ||
| * `code-and-learn` tasks typically fall into this category. | ||
| * `good-first-issue` pull requests may also be suitable. |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
How about:
Pull requests from new contributors (for example code-and-learn tasks) that are low-risk and uncontentious.
- If the aim is to improve the experience of your first node contribution, then let's say that specifically.
- If we say docs or tests only, does that cover source comments? Or whitespace fixes? I feel like specifying the "what" is going to be too complex, but the "why" might be easier.
Sorry, something went wrong.
Comment thread
COLLABORATOR_GUIDE.md
| * `good-first-issue` pull requests may also be suitable. | ||
| * Changes that fix regressions: | ||
| * Regressions that break the workflow (red CI or broken compilation). | ||
| * Regressions that happen right before a release, or reported soon after. |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Maybe: "Fixes that need to be backported to a release line urgently."
If it's reported soon after a release and we decided to leave it till the next one, then it doesn't need to be fast-tracked IMO.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I think this is just listing changes that "can be" fast-tracked, not necessarily "need to be"?
Sorry, something went wrong.
jasnell
approved these changes
Dec 5, 2017
BridgeAR
approved these changes
Dec 10, 2017
jasnell
pushed a commit
that referenced
this pull request
Jan 10, 2018
PR-URL: #17379 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
evanlucas
pushed a commit
that referenced
this pull request
Jan 22, 2018
PR-URL: #17379 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
PR-URL: #17379 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2018
PR-URL: #17379 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2018
PR-URL: #17379 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #17332
Checklist
Affected core subsystem(s)
dec,meta