FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools,test: use Execute instead of check_output by refack · Pull Request #17381 · nodejs/node · GitHub

/ node Public

tools,test: use Execute instead of check_output - #17381

Merged
refack merged 1 commit into
nodejs:masterfrom
refack:improve-testpy-subprocess
Nov 30, 2017
ConversationCommits (1)ChecksFiles changed
Merged

tools,test: use Execute instead of check_output#17381
refack merged 1 commit into
nodejs:masterfrom
refack:improve-testpy-subprocess

Conversation

refack commented Nov 29, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

subprocess.check_output (f31cf56) is a python2.7 only feature. Using Execute allows
keeping python2.6 compatibility

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

tools,test

refack added the regression Issues related to regressions. label Nov 29, 2017
nodejs-github-bot added test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Nov 29, 2017
refack mentioned this pull request Nov 29, 2017
Closed
4 tasks

refack commented Nov 29, 2017

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/11787/

refack added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 29, 2017

refack commented Nov 29, 2017

Copy link
Copy Markdown
Contributor Author

Seems like this is the safest way to restore CI to green, so we should to fast-track this.

refack commented Nov 29, 2017

Copy link
Copy Markdown
Contributor Author

New CI: https://ci.nodejs.org/job/node-test-commit/14441/

Trott approved these changes Nov 29, 2017
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Rubber-stamp LGTM

Trott added the python PRs and issues that require attention from people who are familiar with Python. label Nov 29, 2017
refack mentioned this pull request Nov 29, 2017
Merged
MylesBorins approved these changes Nov 29, 2017
View reviewed changes

MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Rubber Stamp LGTM including fast-track

bnoordhuis approved these changes Nov 29, 2017
View reviewed changes
Comment thread tools/test.py Outdated

bnoordhuis Nov 29, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Since you're here, can you use single quotes?

refack Nov 29, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

ack

gibfahn commented Nov 29, 2017

Copy link
Copy Markdown
Member

+1 on fast-track

refack force-pushed the improve-testpy-subprocess branch from 12f9684 to f4d1bb8 Compare November 29, 2017 13:50
refack force-pushed the improve-testpy-subprocess branch from f4d1bb8 to 6998621 Compare November 29, 2017 13:52

refack commented Nov 29, 2017

Copy link
Copy Markdown
Contributor Author

lite CI: https://ci.nodejs.org/job/node-test-commit-light/1/

tools,test: use Execute instead of check_output
fff3792 
subprocess.check_output is a python2.7 only feature. Using Execute
allows keeping python2.6 compatibility

PR-URL: nodejs#17381
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
refack force-pushed the improve-testpy-subprocess branch from 6998621 to fff3792 Compare November 30, 2017 01:34
refack merged commit fff3792 into nodejs:master Nov 30, 2017
refack deleted the improve-testpy-subprocess branch November 30, 2017 01:36
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
tools,test: use Execute instead of check_output
8420457 
subprocess.check_output is a python2.7 only feature. Using Execute
allows keeping python2.6 compatibility

PR-URL: #17381
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
tools,test: use Execute instead of check_output
8bd74c4 
subprocess.check_output is a python2.7 only feature. Using Execute
allows keeping python2.6 compatibility

PR-URL: #17381
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
tools,test: use Execute instead of check_output
28a0c10 
subprocess.check_output is a python2.7 only feature. Using Execute
allows keeping python2.6 compatibility

PR-URL: #17381
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

gibfahn commented Dec 19, 2017

Copy link
Copy Markdown
Member

Backport requested here: #16329 (comment)

gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
tools,test: use Execute instead of check_output
38b0da7 
subprocess.check_output is a python2.7 only feature. Using Execute
allows keeping python2.6 compatibility

PR-URL: #17381
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
gibfahn mentioned this pull request Dec 20, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes
Trott Trott approved these changes
jasnell Awaiting requested review from jasnell
addaleax Awaiting requested review from addaleax
BridgeAR Awaiting requested review from BridgeAR
+2 more reviewers
MylesBorins MylesBorins approved these changes
gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. python PRs and issues that require attention from people who are familiar with Python. regression Issues related to regressions. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL