FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: Add test case for missing branch by Leko · Pull Request #17418 · nodejs/node · GitHub

/ node Public

test: Add test case for missing branch - #17418

Closed
Leko wants to merge 2 commits into
nodejs:masterfrom
Leko:enhance_crypto_coverage
ConversationCommits (2)ChecksFiles changed
Closed

test: Add test case for missing branch#17418
Leko wants to merge 2 commits into
nodejs:masterfrom
Leko:enhance_crypto_coverage

Conversation

Leko commented Dec 1, 2017

Copy link
Copy Markdown
Contributor

Enhance crypto/util coverage.
I added:

  • The case of id is string, flags is number
  • The case of flags is not 0

Current coverage:

https://coverage.nodejs.org/coverage-06e1b0386196f8f8/root/internal/crypto/util.js.html

After this PR:

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test: Add test case for missing branch
8dade49 
- The case of id is string, flags is number
- The case of flags is not 0
nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2017
cjihrig approved these changes Dec 1, 2017
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, but perhaps use the name invalidEngineName instead of notExistsEngineName.

addaleax approved these changes Dec 1, 2017
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I like @cjihrig's suggestion too

apapirovski approved these changes Dec 1, 2017
View reviewed changes

apapirovski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM but +1 to @cjihrig's naming suggestion

Leko commented Dec 2, 2017

Copy link
Copy Markdown
Contributor Author

slightly off topic, but what software are you using for visualizing the coverage report

@devsnek I'm using make -j4 coverage-test to generate coverage report.

Leko commented Dec 2, 2017

Copy link
Copy Markdown
Contributor Author

@cjihrig Thank you for review.
I'll rename it as your suggestion.

mscdex added the crypto Issues and PRs related to the crypto subsystem. label Dec 2, 2017

apapirovski commented Dec 2, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/11853/

apapirovski added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 3, 2017

maclover7 commented Dec 3, 2017

Copy link
Copy Markdown
Contributor

windows-fanned failure seems unrelated, landing...

maclover7 self-assigned this Dec 3, 2017

maclover7 commented Dec 3, 2017

Copy link
Copy Markdown
Contributor

Thank you for your contribution, landed in 254b5f0.
❤️ 💚 💙 💛 💜

maclover7 closed this Dec 3, 2017
maclover7 pushed a commit that referenced this pull request Dec 3, 2017
test: add test case for missing branch
254b5f0 
- The case of id is string, flags is number
- The case of flags is not 0

PR-URL: #17418
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Leko deleted the enhance_crypto_coverage branch December 4, 2017 05:31
addaleax removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 7, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: add test case for missing branch
e36d43f 
- The case of id is string, flags is number
- The case of flags is not 0

PR-URL: #17418
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: add test case for missing branch
0afcea2 
- The case of id is string, flags is number
- The case of flags is not 0

PR-URL: #17418
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
MylesBorins mentioned this pull request Dec 12, 2017
Merged
Leko mentioned this pull request Dec 18, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
+2 more reviewers
apapirovski apapirovski approved these changes
maclover7 maclover7 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

maclover7

Labels

crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL