FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

refactor : test-http-request-dont-override-options to use common.mustCall by mithunsasidharan · Pull Request #17438 · nodejs/node · GitHub

/ node Public

refactor : test-http-request-dont-override-options to use common.mustCall - #17438

Closed
mithunsasidharan wants to merge 1 commit into
nodejs:masterfrom
mithunsasidharan:pr_8
ConversationCommits (1)ChecksFiles changed
Closed

refactor : test-http-request-dont-override-options to use common.mustCall#17438
mithunsasidharan wants to merge 1 commit into
nodejs:masterfrom
mithunsasidharan:pr_8

Conversation

mithunsasidharan commented Dec 3, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

refactor : test-http-request-dont-override-options to use common.mustCall as per issue #17169

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 3, 2017
mithunsasidharan changed the title test : refactored test cases in test-http-request-dont-override-options to use countdown test : refactored test-http-request-dont-override-options to use countdown Dec 3, 2017
apapirovski reviewed Dec 3, 2017
View reviewed changes

apapirovski left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This should be refactored to use common.mustCall instead of Countdown since it's supposed to only run 1 request anyway.

(I don't think the changes here are correct since the countdown never goes to 0.)

mscdex added the http Issues or PRs related to the http subsystem. label Dec 3, 2017
mithunsasidharan changed the title test : refactored test-http-request-dont-override-options to use countdown refactor : test-http-request-dont-override-options to use common.mustCall Dec 3, 2017

mithunsasidharan commented Dec 3, 2017

Copy link
Copy Markdown
Contributor Author

@apapirovski : Thanks for the feedback. I've updated the PR to include the recommended changes. Kindly review the PR now.

apapirovski reviewed Dec 3, 2017
View reviewed changes
Comment thread test/parallel/test-http-request-dont-override-options.js Outdated

apapirovski Dec 3, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

common.mustCall should be added to this function.

Comment thread test/parallel/test-http-request-dont-override-options.js Outdated

apapirovski Dec 3, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We don't need to call on here since listen (line 13) accepts a callback.

Comment thread test/parallel/test-http-request-dont-override-options.js Outdated

apapirovski Dec 3, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You could just put server.close() after res.resume() and then validate the assert conditions there (lines 37-42). That way we don't need the process.on('exit').

Comment thread test/parallel/test-http-request-dont-override-options.js Outdated

apapirovski Dec 3, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This can be removed if server.close() is added somewhere as per above.

mithunsasidharan commented Dec 3, 2017

Copy link
Copy Markdown
Contributor Author

@apapirovski : Thanks for the feedback. I've updated the PR addressing the review comments. Kindly review the PR. Thanks!

apapirovski reviewed Dec 3, 2017
View reviewed changes
Comment thread test/parallel/test-http-request-dont-override-options.js Outdated

apapirovski Dec 3, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can this be just inlined above? The name isn't very descriptive (and could confuse someone in the future) since there's only 1 test, not many.

server.listen(0, () => {...});

mithunsasidharan Dec 3, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@apapirovski : Thanks for the feedback. I've updated the PR as per the comment and also shortened the commit message. Kindly review the PR now. Thanks !

apapirovski commented Dec 3, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/11860/

maclover7 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 5, 2017

maclover7 commented Dec 6, 2017

Copy link
Copy Markdown
Contributor

Landing...

maclover7 self-assigned this Dec 6, 2017

maclover7 commented Dec 6, 2017

Copy link
Copy Markdown
Contributor

Landed in 00c5b06

maclover7 closed this Dec 6, 2017
addaleax removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 7, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: update test-http-request-dont-override-options to use common.mu…
c893d38 
…stCall

PR-URL: #17438
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: update test-http-request-dont-override-options to use common.mu…
d8018bc 
…stCall

PR-URL: #17438
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
test: update test-http-request-dont-override-options to use common.mu…
d1d547d 
…stCall

PR-URL: #17438
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
test: update test-http-request-dont-override-options to use common.mu…
0f6ce05 
…stCall

PR-URL: #17438
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
test: update test-http-request-dont-override-options to use common.mu…
6b18b35 
…stCall

PR-URL: #17438
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
gibfahn mentioned this pull request Dec 20, 2017
Merged
MylesBorins mentioned this pull request Dec 20, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
+3 more reviewers
apapirovski apapirovski approved these changes
maclover7 maclover7 approved these changes
daxlab daxlab approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

maclover7

Labels

http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL