FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: replace fs.accessSync with common.fileExists by Leko · Pull Request #17446 · nodejs/node · GitHub

/ node Public

test: replace fs.accessSync with common.fileExists - #17446

Closed
Leko wants to merge 2 commits into
nodejs:masterfrom
Leko:replace_fs-accessSync_with_common-fileExists
ConversationCommits (2)ChecksFiles changed
Closed

test: replace fs.accessSync with common.fileExists#17446
Leko wants to merge 2 commits into
nodejs:masterfrom
Leko:replace_fs-accessSync_with_common-fileExists

Conversation

Leko commented Dec 4, 2017

Copy link
Copy Markdown
Contributor

replace fs.accessSync with common.fileExists in test/parallel/test-npm-install.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 4, 2017
mscdex added the npm Issues and PRs related to the npm client dependency or the npm registry. label Dec 4, 2017

lpinca commented Dec 4, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11866/

cjihrig reviewed Dec 4, 2017
View reviewed changes
Comment thread test/parallel/test-npm-install.js Outdated
assert.doesNotThrow(function() {
fs.accessSync(`${installDir}/node_modules/package-name`);
});
assert(common.fileExists(`${installDir}/node_modules/package-name`));

cjihrig Dec 4, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

fs.existsSync() would be a better choice.

apapirovski Dec 4, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This raises the question of whether common.fileExists is very aptly named or not... it uses accessSync under the hood rather than existsSync.

cjihrig Dec 4, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I mentioned this somewhere else recently. fs.existsSync() was marked for deprecation a while back, so common.fileExists() was added to take its place in the tests. After enough user outrage feedback, existsSync() was undeprecated. common.fileExists() is now redundant and should be removed #codeandlearn #goodfirstcontribution.

Leko Dec 4, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@cjihrig @apapirovski Thank you for review.
Should I replace common.fileExists with fs.existsSync ?

cjihrig Dec 5, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@Leko I would change it.

Leko Dec 6, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I got it. I'll update it.

apapirovski commented Dec 7, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/11960/

(given the changes a new one is needed)

apapirovski commented Dec 8, 2017

Copy link
Copy Markdown
Contributor

Landed in bf26d92

apapirovski closed this Dec 8, 2017
apapirovski pushed a commit that referenced this pull request Dec 8, 2017
test: replace fs.accessSync with fs.existsSync
bf26d92 
PR-URL: #17446
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
apapirovski mentioned this pull request Dec 9, 2017
Closed
2 tasks
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: replace fs.accessSync with fs.existsSync
3b5d341 
PR-URL: #17446
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: replace fs.accessSync with fs.existsSync
928aecc 
PR-URL: #17446
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
test: replace fs.accessSync with fs.existsSync
6e7ace2 
PR-URL: #17446
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
test: replace fs.accessSync with fs.existsSync
d693dac 
PR-URL: #17446
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
test: replace fs.accessSync with fs.existsSync
a81f732 
PR-URL: #17446
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn mentioned this pull request Dec 20, 2017
Merged
MylesBorins mentioned this pull request Dec 20, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
BridgeAR BridgeAR approved these changes
+1 more reviewer
apapirovski apapirovski approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

npm Issues and PRs related to the npm client dependency or the npm registry. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL