FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: remove space in man pages linking regex by DiegoRBaquero · Pull Request #17479 · nodejs/node · GitHub

/ node Public

tools: remove space in man pages linking regex - #17479

Closed
DiegoRBaquero wants to merge 2 commits into
nodejs:masterfrom
DiegoRBaquero:patch-1
ConversationCommits (2)ChecksFiles changed
Closed

tools: remove space in man pages linking regex#17479
DiegoRBaquero wants to merge 2 commits into
nodejs:masterfrom
DiegoRBaquero:patch-1

Conversation

DiegoRBaquero commented Dec 6, 2017

Copy link
Copy Markdown
Contributor

Removes space in regex for man pages linking in docs generation

Checklist
Affected core subsystem(s)

tools

Stumbled upon signal(7) no being linked in child_process because in the markdown file it happens to be the start of the line, so there's no space.

tools: remove space in man pages linking regex
6c031ba 
Removes space in regex for man pages linking in docs generation
nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Dec 6, 2017
lpinca approved these changes Dec 6, 2017
View reviewed changes
Comment thread tools/doc/html.js Outdated
function linkManPages(text) {
return text.replace(
/ ([a-z.]+)\((\d)([a-z]?)\)/gm,
/([a-z.]+)\((\d)([a-z]?)\)/gm,

lpinca Dec 6, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nit: I'd replace the space with \b.

Trott commented Dec 6, 2017

Copy link
Copy Markdown
Member

Definitely prefer it be replaced by \b rather than removed....

tools: remove space in man pages linking regex
96b7a5e 
Removes space in regex for man pages linking in docs generation

DiegoRBaquero commented Dec 6, 2017

Copy link
Copy Markdown
Contributor Author

Changed to \b, thanks @lpinca , learned something new.

apapirovski commented Dec 8, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/11987/

apapirovski pushed a commit that referenced this pull request Dec 9, 2017
tools: replace space with \b in regex
ea77b33 
PR-URL: #17479
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

apapirovski commented Dec 9, 2017

Copy link
Copy Markdown
Contributor

Landed in ea77b33

apapirovski closed this Dec 9, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
tools: replace space with \b in regex
2e1a526 
PR-URL: #17479
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
tools: replace space with \b in regex
70cfe68 
PR-URL: #17479
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Dec 12, 2017
Merged
This was referenced Dec 12, 2017
Closed
Closed
DiegoRBaquero deleted the patch-1 branch December 18, 2017 02:41
DiegoRBaquero added a commit to DiegoRBaquero/node that referenced this pull request Dec 18, 2017
tools: fix man pages linking regex
5af4822 
The change to word boundary was breaking many doc pages. This reverts the word boundary back to space.

Fixes: nodejs#17637
Fixes: nodejs#17694
Refs: nodejs#17479
DiegoRBaquero mentioned this pull request Dec 18, 2017
Closed
1 task
DiegoRBaquero added a commit to DiegoRBaquero/node that referenced this pull request Dec 19, 2017
tools: fix man pages linking regex
fa42177 
The change to word boundary was breaking many doc pages. This replace the word boundary with a matching group of space or beginning of line.

Fixes: nodejs#17637
Fixes: nodejs#17694
Refs: nodejs#17479
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
tools: replace space with \b in regex
9868ce5 
PR-URL: #17479
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
tools: replace space with \b in regex
3e4ca90 
PR-URL: #17479
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn mentioned this pull request Dec 20, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
tools: fix man pages linking regex
d2699cf 
The change to word boundary was breaking many doc pages. This reverts
the word boundary back to space.

PR-URL: #17724
Fixes: #17694
Refs: #17479
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
tools: fix man pages linking regex
22d755e 
The change to word boundary was breaking many doc pages. This reverts
the word boundary back to space.

PR-URL: #17724
Fixes: #17694
Refs: #17479
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
tools: fix man pages linking regex
7ef876d 
The change to word boundary was breaking many doc pages. This reverts
the word boundary back to space.

PR-URL: #17724
Fixes: #17694
Refs: #17479
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
tools: fix man pages linking regex
ee027ae 
The change to word boundary was breaking many doc pages. This reverts
the word boundary back to space.

PR-URL: #17724
Fixes: #17694
Refs: #17479
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
tools: fix man pages linking regex
90fe169 
The change to word boundary was breaking many doc pages. This reverts
the word boundary back to space.

PR-URL: #17724
Fixes: #17694
Refs: #17479
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
+1 more reviewer
maclover7 maclover7 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL