FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix flaky async-hooks/test-graph.signal by Trott · Pull Request #17509 · nodejs/node · GitHub

/ node Public

test: fix flaky async-hooks/test-graph.signal - #17509

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-flake
ConversationCommits (1)ChecksFiles changed
Closed

test: fix flaky async-hooks/test-graph.signal#17509
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-flake

Conversation

Trott commented Dec 6, 2017

Copy link
Copy Markdown
Member

Make sure event loop remains open long enough for signal to be received.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test async-hooks

Trott added async_hooks Issues and PRs related to the async hooks subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. wip Issues and PRs that are still a work in progress. test Issues and PRs related to the tests. labels Dec 6, 2017
nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Dec 6, 2017
test: fix flaky async-hooks/test-graph.signal
820aeb4 
Make sure event loop remains open long enough for signal to be received.

Fixes: nodejs#14568

Trott commented Dec 6, 2017 •
edited
Loading

Copy link
Copy Markdown
Member Author

Stress test on master showing failures (although only 2 failures in 19200 runs):
https://ci.nodejs.org/job/node-stress-single-test/1559/nodes=centos7-64/console

Stress test with this PR: https://ci.nodejs.org/job/node-stress-single-test/1561/nodes=centos7-64/console

Trott commented Dec 6, 2017

Copy link
Copy Markdown
Member Author

Stress test came back green! Removing the in progress label.

Trott mentioned this pull request Dec 6, 2017
Closed
Trott removed the wip Issues and PRs that are still a work in progress. label Dec 6, 2017

Trott commented Dec 7, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/11925/

Trott commented Dec 7, 2017

Copy link
Copy Markdown
Member Author

Lint error appears to be caused by #17460 and unrelated to this.

Trott commented Dec 7, 2017

Copy link
Copy Markdown
Member Author

Running CI again now that linter has been unbroken. Unrelated build failure on macOS too, so canceled the whole thing and starting again...

CI: https://ci.nodejs.org/job/node-test-pull-request/11928/

Trott commented Dec 7, 2017

Copy link
Copy Markdown
Member Author

CI failures are two known unrelated flaky tests and a build failure.

Re-running the build failure: https://ci.nodejs.org/job/node-test-commit-linuxone/10970/

Trott added a commit to Trott/io.js that referenced this pull request Dec 8, 2017
test: fix flaky async-hooks/test-graph.signal
8997026 
Make sure event loop remains open long enough for signal to be received.

PR-URL: nodejs#17509
Fixes: nodejs#14568
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

Trott commented Dec 8, 2017

Copy link
Copy Markdown
Member Author

Landed in 8997026

Trott closed this Dec 8, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: fix flaky async-hooks/test-graph.signal
da5dd45 
Make sure event loop remains open long enough for signal to be received.

PR-URL: #17509
Fixes: #14568
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: fix flaky async-hooks/test-graph.signal
0f40069 
Make sure event loop remains open long enough for signal to be received.

PR-URL: #17509
Fixes: #14568
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: fix flaky async-hooks/test-graph.signal
f5a1e6c 
Make sure event loop remains open long enough for signal to be received.

PR-URL: #17509
Fixes: #14568
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
test: fix flaky async-hooks/test-graph.signal
b016cbb 
Make sure event loop remains open long enough for signal to be received.

PR-URL: #17509
Fixes: #14568
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
test: fix flaky async-hooks/test-graph.signal
683daea 
Make sure event loop remains open long enough for signal to be received.

PR-URL: #17509
Fixes: #14568
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
gibfahn mentioned this pull request Dec 20, 2017
Merged
Trott deleted the fix-flake branch January 13, 2022 22:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cjihrig cjihrig approved these changes
richardlau richardlau approved these changes
+2 more reviewers
refack refack approved these changes
evanlucas evanlucas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL