FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: remove unused link reference in child_process.md by apapirovski · Pull Request #17510 · nodejs/node · GitHub

/ node Public

doc: remove unused link reference in child_process.md - #17510

Closed
apapirovski wants to merge 1 commit into
nodejs:masterfrom
apapirovski:fix-child-process-md-lint
ConversationCommits (1)ChecksFiles changed
Closed

doc: remove unused link reference in child_process.md#17510
apapirovski wants to merge 1 commit into
nodejs:masterfrom
apapirovski:fix-child-process-md-lint

Conversation

apapirovski commented Dec 7, 2017

Copy link
Copy Markdown
Contributor

Unbreaking the build. Would like to land almost immediately.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

apapirovski added the doc Issues and PRs related to the documentations. label Dec 7, 2017
nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Dec 7, 2017
apapirovski mentioned this pull request Dec 7, 2017
Closed
2 tasks
apapirovski requested a review from Trott December 7, 2017 00:11

apapirovski commented Dec 7, 2017

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/11927/

maclover7 approved these changes Dec 7, 2017
View reviewed changes

maclover7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

maclover7 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Dec 7, 2017

Trott commented Dec 7, 2017

Copy link
Copy Markdown
Member

Absolutely 👍 to fast-tracking.

apapirovski changed the title Fix child process md lint doc: remove unused link reference in child_process.md Dec 7, 2017

apapirovski commented Dec 7, 2017

Copy link
Copy Markdown
Contributor Author

Will wait for the linter to finish then land this since it has 2 approvals now.

Trott commented Dec 7, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

FYI (for @apapirovski but also for any other Collaborators because I don't think it's been widely publicized), for commits like this, you can choose the node-test-pull-request-lite task which will only run the linter and (because it's fast) the tests on linux-one.

Trott mentioned this pull request Dec 7, 2017
Closed
3 tasks

apapirovski commented Dec 7, 2017

Copy link
Copy Markdown
Contributor Author

@Trott thanks. Good to know!

apapirovski commented Dec 7, 2017

Copy link
Copy Markdown
Contributor Author

Ok, we've been unbroken. Sorry about that.

Landed in c892f6f

apapirovski closed this Dec 7, 2017
apapirovski deleted the fix-child-process-md-lint branch December 7, 2017 00:19
apapirovski added a commit that referenced this pull request Dec 7, 2017
doc: remove unused link reference
c892f6f 
PR-URL: #17510
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
addaleax removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 7, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
doc: remove unused link reference
f10fec8 
PR-URL: #17510
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
doc: remove unused link reference
35d492c 
PR-URL: #17510
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
doc: remove unused link reference
e515355 
PR-URL: #17510
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
doc: remove unused link reference
4d826f0 
PR-URL: #17510
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
gibfahn mentioned this pull request Dec 20, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
+1 more reviewer
maclover7 maclover7 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL