FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: mention node-test-pull-request-lite job by maclover7 · Pull Request #17513 · nodejs/node · GitHub

/ node Public

doc: mention node-test-pull-request-lite job - #17513

Closed
maclover7 wants to merge 2 commits into
nodejs:masterfrom
maclover7:jm-add-job
ConversationCommits (2)ChecksFiles changed
Closed

doc: mention node-test-pull-request-lite job#17513
maclover7 wants to merge 2 commits into
nodejs:masterfrom
maclover7:jm-add-job

Conversation

maclover7 commented Dec 7, 2017

Copy link
Copy Markdown
Contributor
Checklist
Affected core subsystem(s)

doc

maclover7 requested a review from Trott December 7, 2017 00:28
nodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 7, 2017
apapirovski approved these changes Dec 7, 2017
View reviewed changes

apapirovski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

vsemozhetbyt commented Dec 7, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

LinuxONE includes doc building test, right? Does this job suffice for doc-only PRs?

maclover7 commented Dec 7, 2017

Copy link
Copy Markdown
Contributor Author

LinuxONE includes doc building test, right? Does this job suffice for doc-only PRs?

@vsemozhetbyt Hmm, interesting question. My initial thought is that yes, it would be okay, although this is probably something that would need a separate issue opened for more discussion.

Trott approved these changes Dec 7, 2017
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Maybe instead of "quick fixes" say "trivial changes" or even "trivial doc-only changes"?

lpinca approved these changes Dec 7, 2017
View reviewed changes

lpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

+1 to @Trott's suggestion.

maclover7 commented Dec 7, 2017

Copy link
Copy Markdown
Contributor Author

updated @Trott @lpinca

Trott commented Dec 7, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/5/

(See what I did there?)

maclover7 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 7, 2017

maclover7 commented Dec 8, 2017

Copy link
Copy Markdown
Contributor Author

Landing...

maclover7 self-assigned this Dec 8, 2017

maclover7 commented Dec 8, 2017

Copy link
Copy Markdown
Contributor Author

Landed in de3a7db

maclover7 closed this Dec 8, 2017
maclover7 deleted the jm-add-job branch December 8, 2017 14:39
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
doc: mention node-test-pull-request-lite job
835cc23 
PR-URL: #17513
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
doc: mention node-test-pull-request-lite job
6aa6d41 
PR-URL: #17513
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins mentioned this pull request Dec 12, 2017
Merged
addaleax removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 13, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
doc: mention node-test-pull-request-lite job
ee52ce9 
PR-URL: #17513
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
doc: mention node-test-pull-request-lite job
4035686 
PR-URL: #17513
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
doc: mention node-test-pull-request-lite job
418ee1c 
PR-URL: #17513
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
gibfahn mentioned this pull request Dec 20, 2017
Merged
MylesBorins mentioned this pull request Dec 20, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
+1 more reviewer
apapirovski apapirovski approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

maclover7

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL