| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
Limit of countdown can be outCount*inCount instead of 1.
Sorry, something went wrong.
There was a problem hiding this comment.
Can replace this whole if block with countdown.dec();
Sorry, something went wrong.
There was a problem hiding this comment.
Can remove responseCount variable.
Sorry, something went wrong.
|
Thanks for contribution!!! Please, do use make lint/vcbuild lint before pr. |
Sorry, something went wrong.
|
@sreepurnajasti Thanks for the comments, I am pretty sure that I did run make lint, maybe I missed something 🤔 . I will run it again. Do you think this would be ok ? ...
const countdown = new Countdown(
outCount * inCount,
common.mustCall(() => server.close())
);
let onRequest = common.mustNotCall(); // Temporary
const p = new Promise((resolve) => {
onRequest = common.mustCall((res) => {
if (countdown.dec() === 0) {
resolve();
}
if (!shouldFail)
res.resume();
}, outCount * inCount);
});
... |
Sorry, something went wrong.
|
That should work. You can also run make -j4 test to make sure the test runs as expected. Or to run a single test, run tools/test.py --mode=release parallel/test-http-agent. |
Sorry, something went wrong.
|
Thanks @apapirovski, I have already run all tests and linter 😄 after amending the last commit |
Sorry, something went wrong.
Sorry, something went wrong.
|
@apapirovski Do you think that this failure is related to my change? To me seems like it is not, or is it? 🤔 |
Sorry, something went wrong.
|
@fedekau Completely unrelated, this PR is all good :) |
Sorry, something went wrong.
Sorry, something went wrong.
PR-URL: #17537 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
|
Thanks @apapirovski and @sreepurnajasti I hope this is the first of many PRs 💪 |
Sorry, something went wrong.
PR-URL: #17537 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
PR-URL: #17537 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
PR-URL: #17537 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
PR-URL: #17537 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
PR-URL: #17537 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
| Back | FazBrowse Home | New Git URL |
Hi, this is my first PR to node!
I started by tackling one of the tests listed in #17169, in particular the test/parallel/test-http-agent.js test. Hopefully everything looks good to you, otherwise let me know what can be improved 😄
Checklist