FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: simplify and clarify FIPS text in BUILDING.md by Trott · Pull Request #17538 · nodejs/node · GitHub

/ node Public

doc: simplify and clarify FIPS text in BUILDING.md - #17538

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fips-building
ConversationCommits (1)ChecksFiles changed
Closed

doc: simplify and clarify FIPS text in BUILDING.md#17538
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fips-building

Conversation

Trott commented Dec 7, 2017

Copy link
Copy Markdown
Member

Fixes: #17536

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Dec 7, 2017
Trott requested a review from mhdawson December 7, 2017 22:51
Trott mentioned this pull request Dec 7, 2017
Closed

Trott commented Dec 7, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/7/

mhdawson approved these changes Dec 8, 2017
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

maclover7 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 8, 2017
Trott added a commit to Trott/io.js that referenced this pull request Dec 10, 2017
doc: simplify and clarify FIPS text in BUILDING.md
4426d75 
PR-URL: nodejs#17538
Fixes: nodejs#17536
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

Trott commented Dec 10, 2017

Copy link
Copy Markdown
Member Author

Landed in 4426d75.

Trott closed this Dec 10, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
doc: simplify and clarify FIPS text in BUILDING.md
30f5a26 
PR-URL: #17538
Fixes: #17536
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
doc: simplify and clarify FIPS text in BUILDING.md
a965dda 
PR-URL: #17538
Fixes: #17536
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
MylesBorins mentioned this pull request Dec 12, 2017
Merged
addaleax removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 13, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
doc: simplify and clarify FIPS text in BUILDING.md
dcee5ed 
PR-URL: #17538
Fixes: #17536
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
doc: simplify and clarify FIPS text in BUILDING.md
8e4cb1b 
PR-URL: #17538
Fixes: #17536
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
doc: simplify and clarify FIPS text in BUILDING.md
0b45766 
PR-URL: #17538
Fixes: #17536
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
gibfahn mentioned this pull request Dec 20, 2017
Merged
MylesBorins mentioned this pull request Dec 20, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
doc: simplify and clarify FIPS text in BUILDING.md
26e0fa8 
PR-URL: #17538
Fixes: #17536
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Trott deleted the fips-building branch January 13, 2022 22:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
+2 more reviewers
maclover7 maclover7 approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BUILDING.md references p. 60 of a 40 page security policy document

7 participants

Back | FazBrowse Home | New Git URL