tools: add lowercase-name-for-primitive eslint rule - #17568
Closed
starkwang wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
addaleax
approved these changes
Dec 9, 2017
targos
approved these changes
Dec 9, 2017
Comment thread
tools/eslint-rules/lowercase-name-for-primitive.js
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
s/captialized/lowercase
Sorry, something went wrong.
Primitives should use lowercase in error message. refs: nodejs#16401
starkwang
force-pushed
the
lowercase-for-primitive
branch
from
1d2fbce to
ea94065
Compare
December 9, 2017 14:43
BridgeAR
approved these changes
Dec 9, 2017
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jasnell
approved these changes
Dec 12, 2017
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 13, 2017
Primitives should use lowercase in error message. Refs: nodejs#16401 PR-URL: nodejs#17568 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primitive types should use lowercase in error message.
refs: #16383, #16401
Checklist
Affected core subsystem(s)
tools, test