FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix modules.md export example by apapirovski · Pull Request #17579 · nodejs/node · GitHub

/ node Public

doc: fix modules.md export example - #17579

Closed
apapirovski wants to merge 1 commit into
nodejs:masterfrom
apapirovski:fix-modules-doc-square-example
ConversationCommits (1)ChecksFiles changed
Closed

doc: fix modules.md export example#17579
apapirovski wants to merge 1 commit into
nodejs:masterfrom
apapirovski:fix-modules-doc-square-example

Conversation

apapirovski commented Dec 9, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

A commit landed recently that made one of our examples no longer execute correctly and instead throw an Error. Updated it to use ES6 and actually make sense.

In hindsight, @Trott's suggestion of adjusting the original wording would've been good but here we are... Since it was a first-time contributor, I would prefer not to revert their changes.

Refs: #17364

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

apapirovski added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 9, 2017
nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Dec 9, 2017

apapirovski commented Dec 9, 2017

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/9/

apapirovski commented Dec 11, 2017

Copy link
Copy Markdown
Contributor Author

/cc @Trott could you please have a look since you commented in the original PR? Would like to land this since the current example is broken.

apapirovski commented Dec 12, 2017

Copy link
Copy Markdown
Contributor Author

Landed in ec6c063

apapirovski deleted the fix-modules-doc-square-example branch December 12, 2017 00:44
apapirovski added a commit that referenced this pull request Dec 12, 2017
doc: fix modules.md export example
ec6c063 
Arrow functions cannot be called with the new keyword,
convert to ES6 classes instead.

PR-URL: #17579
Refs: #17364
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
doc: fix modules.md export example
bc13386 
Arrow functions cannot be called with the new keyword,
convert to ES6 classes instead.

PR-URL: #17579
Refs: #17364
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
doc: fix modules.md export example
ccffbd9 
Arrow functions cannot be called with the new keyword,
convert to ES6 classes instead.

PR-URL: #17579
Refs: #17364
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
doc: fix modules.md export example
329f3de 
Arrow functions cannot be called with the new keyword,
convert to ES6 classes instead.

PR-URL: #17579
Refs: #17364
Reviewed-By: Rich Trott <rtrott@gmail.com>
gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
doc: fix modules.md export example
545f5a8 
Arrow functions cannot be called with the new keyword,
convert to ES6 classes instead.

PR-URL: #17579
Refs: #17364
Reviewed-By: Rich Trott <rtrott@gmail.com>
gibfahn mentioned this pull request Dec 20, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
doc: fix modules.md export example
d85a635 
Arrow functions cannot be called with the new keyword,
convert to ES6 classes instead.

PR-URL: #17579
Refs: #17364
Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. module Issues and PRs related to the module subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL