FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: don't lint-md as part of main lint target by refack · Pull Request #17587 · nodejs/node · GitHub

/ node Public

tools: don't lint-md as part of main lint target - #17587

Closed
refack wants to merge 1 commit into
nodejs:masterfrom
refack:skip-lint-md
ConversationCommits (1)ChecksFiles changed
Closed

tools: don't lint-md as part of main lint target#17587
refack wants to merge 1 commit into
nodejs:masterfrom
refack:skip-lint-md

Conversation

refack commented Dec 10, 2017

Copy link
Copy Markdown
Contributor

Followup to #17320.
As per discussion in TSC Meeting from 2017-12-06 skip linting markdown files as part of the lint target.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools,build

refack requested a review from MylesBorins December 10, 2017 17:21
nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Dec 10, 2017

refack commented Dec 10, 2017

Copy link
Copy Markdown
Contributor Author

#17330 will complement this change, in that is minimizes git noise even when running lint-md-build.

refack commented Dec 10, 2017

Copy link
Copy Markdown
Contributor Author

preliminary CI: https://ci.nodejs.org/job/node-test-pull-request-lite/

refack added the tools Issues and PRs related to the tools directory. label Dec 10, 2017
refack mentioned this pull request Dec 11, 2017
Closed

BridgeAR commented Dec 11, 2017

Copy link
Copy Markdown
Member

Hm, I would really like to find a good solution for this. I like the linter a lot. But oh well, I guess it is to run one more command for most PRs now.

MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 11, 2017
MylesBorins approved these changes Dec 11, 2017
View reviewed changes

MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM we should land asap

MylesBorins commented Dec 11, 2017

Copy link
Copy Markdown
Contributor

@BridgeAR this is a temporary solution while we figure out a better way to maintain dependencies inside of the tree (to avoid landing 2k new files in tree). I'm very much into getting a better solution together and bringing the linter back into the fray

MylesBorins commented Dec 11, 2017

Copy link
Copy Markdown
Contributor

landed in 51a7d97

MylesBorins pushed a commit that referenced this pull request Dec 11, 2017
tools: don't lint-md as part of main lint target
51a7d97 
PR-URL: #17587
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
tools: don't lint-md as part of main lint target
66c4b6b 
PR-URL: #17587
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
tools: don't lint-md as part of main lint target
8996418 
PR-URL: #17587
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins mentioned this pull request Dec 12, 2017
Merged
MylesBorins pushed a commit that referenced this pull request May 22, 2018
tools: don't lint-md as part of main lint target
4512116 
PR-URL: #17587
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Jun 14, 2018
tools: don't lint-md as part of main lint target
49f3e04 
PR-URL: #17587
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins mentioned this pull request Jul 9, 2018
Merged
refack deleted the skip-lint-md branch July 13, 2018 15:54
refack mentioned this pull request Jul 13, 2018
Closed
3 tasks
rvagg pushed a commit that referenced this pull request Aug 16, 2018
tools: don't lint-md as part of main lint target
f2506d4 
PR-URL: #17587
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cjihrig cjihrig approved these changes
BridgeAR BridgeAR approved these changes
+1 more reviewer
MylesBorins MylesBorins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL