FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

util: allow wildcards in NODE_DEBUG variable by targos · Pull Request #17607 · nodejs/node · GitHub

/ node Public

util: allow wildcards in NODE_DEBUG variable - #17607

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:fix-17605
Closed

util: allow wildcards in NODE_DEBUG variable#17607
targos wants to merge 1 commit into
nodejs:masterfrom
targos:fix-17605

Conversation

targos commented Dec 11, 2017

Copy link
Copy Markdown
Member

Fixes: #17605

Still needs documentation change. I'm opening this for discussion.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

util

nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Dec 11, 2017

Copy link
Copy Markdown
Member

Why not simply allow a regular expression? More flexible and you don't have to write an ad hoc parser for it.

targos commented Dec 11, 2017

Copy link
Copy Markdown
Member Author

Why not simply allow a regular expression?

That would be fine for me too.

starkwang commented Dec 11, 2017
edited
Loading

Copy link
Copy Markdown
Contributor

Why not simply allow a regular expression?

Importing the usage of regular expression may add some complexity and logic confilcts. For example, what will happen if some of section names are contradictory?

--NODE_DEBUG=fs,/^((?!fs).)*$/

The second regular expression matches the string not containing "fs", which is contradictory to the first argument.

Copy link
Copy Markdown
Member

Simple solution: don't write a broken regex. Garbage in, garbage out.

targos commented Dec 12, 2017

Copy link
Copy Markdown
Member Author

Closing in favor of #17609

targos closed this Dec 12, 2017
targos deleted the fix-17605 branch January 2, 2018 14:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

util Issues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL