FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v9.x backport] async_wrap: add provider types for net server by AndreasMadsen · Pull Request #17621 · nodejs/node · GitHub

/ node Public

[v9.x backport] async_wrap: add provider types for net server - #17621

Closed
AndreasMadsen wants to merge 1 commit into
nodejs:v9.x-stagingfrom
AndreasMadsen:backport-17157-to-v9.x
ConversationCommits (1)ChecksFiles changed
Closed

[v9.x backport] async_wrap: add provider types for net server#17621
AndreasMadsen wants to merge 1 commit into
nodejs:v9.x-stagingfrom
AndreasMadsen:backport-17157-to-v9.x

Conversation

AndreasMadsen commented Dec 11, 2017

Copy link
Copy Markdown
Member

Original PR: #17157

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

async_wrap

async_wrap: add provider types for net server
ad0934c 
Adds `TCPSERVERWRAP` and `PIPESERVERWRAP` as provider types. This
makes it possible to distinguish servers from connections.
nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Dec 11, 2017
AndreasMadsen changed the base branch from master to v9.x-staging December 11, 2017 23:27
AndreasMadsen mentioned this pull request Dec 11, 2017
Closed
4 tasks

AndreasMadsen commented Dec 11, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/12049/

AndreasMadsen removed build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Dec 11, 2017

MylesBorins commented Dec 12, 2017

Copy link
Copy Markdown
Contributor

landed in b191c9c

MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
async_wrap: add provider types for net server
b191c9c 
Adds `TCPSERVERWRAP` and `PIPESERVERWRAP` as provider types. This
makes it possible to distinguish servers from connections.

Backport-PR-URL: #17621
PR-URL: #17157
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
async_wrap: add provider types for net server
c2a9e0d 
Adds `TCPSERVERWRAP` and `PIPESERVERWRAP` as provider types. This
makes it possible to distinguish servers from connections.

Backport-PR-URL: #17621
PR-URL: #17157
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
async_wrap: add provider types for net server
e0ce7cf 
Adds `TCPSERVERWRAP` and `PIPESERVERWRAP` as provider types. This
makes it possible to distinguish servers from connections.

Backport-PR-URL: #17621
PR-URL: #17157
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL