FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v8.x backport] async_wrap: add provider types for net server by AndreasMadsen · Pull Request #17623 · nodejs/node · GitHub

/ node Public

[v8.x backport] async_wrap: add provider types for net server - #17623

Closed
AndreasMadsen wants to merge 1 commit into
nodejs:v8.x-stagingfrom
AndreasMadsen:backport-17157-to-v8.x
ConversationCommits (1)ChecksFiles changed
Closed

[v8.x backport] async_wrap: add provider types for net server#17623
AndreasMadsen wants to merge 1 commit into
nodejs:v8.x-stagingfrom
AndreasMadsen:backport-17157-to-v8.x

Conversation

AndreasMadsen commented Dec 11, 2017

Copy link
Copy Markdown
Member

Original PR: #17157

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

async_wrap

async_wrap: add provider types for net server
67ca4d7 
Adds `TCPSERVERWRAP` and `PIPESERVERWRAP` as provider types. This
makes it possible to distinguish servers from connections.
nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. v8.x labels Dec 11, 2017
AndreasMadsen mentioned this pull request Dec 11, 2017
Closed
4 tasks

AndreasMadsen commented Dec 11, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/12048/

AndreasMadsen removed the lib / src Issues and PRs related to general changes in the lib or src directory. label Dec 11, 2017
AndreasMadsen changed the title [v8.x backport] async_wrap: add provider types for net server #17621 [v8.x backport] async_wrap: add provider types for net server Dec 13, 2017
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
async_wrap: add provider types for net server
8fd61e1 
Adds `TCPSERVERWRAP` and `PIPESERVERWRAP` as provider types. This
makes it possible to distinguish servers from connections.

PR-URL: #17157
Backport-PR-URL: #17623
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

gibfahn commented Dec 19, 2017

Copy link
Copy Markdown
Member

Thanks @AndreasMadsen, landed in 8fd61e1

gibfahn closed this Dec 19, 2017
gibfahn reopened this Dec 20, 2017

gibfahn commented Dec 20, 2017

Copy link
Copy Markdown
Member

My mistake, this is semver-minor, it'll have to wait till the next minor release.

gibfahn added the semver-minor PRs that contain new features and should be released in the next minor version. label Dec 20, 2017

AndreasMadsen commented Jan 16, 2018

Copy link
Copy Markdown
Member Author

This is now included in #18179

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL