repl: refactor tests to not rely on timing - #17828
Closed
bmeck wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
jasnell
approved these changes
Dec 28, 2017
Copy link
Copy Markdown
Member
|
@nodejs/testing @addaleax @Fishrock123 @princejwesley |
Sorry, something went wrong.
Tests relying on synchronous timing have been migrated to use events.
bmeck
force-pushed
the
async-repl-tests
branch
from
bbe4925 to
01e697e
Compare
January 17, 2018 17:34
targos
approved these changes
Jan 20, 2018
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Feb 10, 2018
Tests relying on synchronous timing have been migrated to use events. PR-URL: nodejs#17828 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Copy link
Copy Markdown
Member
|
Hm, this broke multilines in the repl. This can easily be verified with: {
After entering that, it is not possible to type anything anymore. @bmeck do you think you can get this working soon again? Otherwise I guess the best will be to revert it? |
Sorry, something went wrong.
4 tasks
Copy link
Copy Markdown
Member
Author
|
@BridgeAR I'll take a look tomorrow and think I can fix it. |
Sorry, something went wrong.
2 tasks
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Feb 12, 2018
This reverts commit de848ac. The commit broke multiline repl. PR-URL: nodejs#18715 Refs: nodejs#17828 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
cjihrig
added a commit
to cjihrig/node
that referenced
this pull request
Feb 14, 2018
This commit adds a regression test for de848ac, which broke multiline input in the REPL. PR-URL: nodejs#18718 Refs: nodejs#17828 Refs: nodejs#18715 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Copy link
Copy Markdown
Contributor
|
Should this be backported to v9.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label. edit: looks like it was reverted setting don't land |
Sorry, something went wrong.
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Tests relying on synchronous timing have been migrated to use events. PR-URL: nodejs#17828 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
This reverts commit de848ac. The commit broke multiline repl. PR-URL: nodejs#18715 Refs: nodejs#17828 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
This commit adds a regression test for de848ac, which broke multiline input in the REPL. PR-URL: nodejs#18718 Refs: nodejs#17828 Refs: nodejs#18715 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 7, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Aug 7, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Aug 9, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Aug 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests relying on synchronous timing have been migrated to use events.
This is in preparation for more robust testing with the top level await transform. Some minor naming changes were also made to try and make bits more consistent as I was reading them.
Checklist
Affected core subsystem(s)
repl, test