FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

errors: remove ERR_OUTOFMEMORY by tniessen · Pull Request #17877 · nodejs/node · GitHub

/ node Public

errors: remove ERR_OUTOFMEMORY - #17877

Closed
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:nooom
ConversationCommits (1)ChecksFiles changed
Closed

errors: remove ERR_OUTOFMEMORY#17877
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:nooom

Conversation

tniessen commented Dec 27, 2017

Copy link
Copy Markdown
Member

The error code ERR_OUTOFMEMORY was added in e71e71b and is unused ever since 69e6c5a. Apart from not being used within node core, it is the only error code which does not use underscores to separate words (ERR_OUTOFMEMORY vs ERR_OUT_OF_RANGE).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

errors

nodejs-github-bot added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Dec 27, 2017
BridgeAR approved these changes Dec 27, 2017
View reviewed changes

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

In general I am fine with this because http2 is still experimental. But we should never remove a error code from now on. Instead, we should deprecate it. The reason is that otherwise people who run into this error code in a older version can not find a proper explanation for it anymore. We night consider adding a specific area for out-dated codes.

tniessen commented Dec 27, 2017

Copy link
Copy Markdown
Member Author

@BridgeAR While this might generally be true, I don't think it matters in this particular case. The documentation for ERR_OUTOFMEMORY contains no information which is not already in the error message itself.

We night consider adding a specific area for out-dated codes.

+1 if that ever turns out to be necessary.

tniessen commented Dec 29, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/12344/

tniessen commented Dec 29, 2017

Copy link
Copy Markdown
Member Author

Landed in a82b1b7.

tniessen closed this Dec 29, 2017
tniessen added a commit that referenced this pull request Dec 29, 2017
errors: remove ERR_OUTOFMEMORY
a82b1b7 
PR-URL: #17877
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins commented Jan 9, 2018

Copy link
Copy Markdown
Contributor

This does not land cleanly on v9.x, could it be backported?

tniessen added a commit to tniessen/node that referenced this pull request Jan 11, 2018
errors: remove ERR_OUTOFMEMORY
7fa5a6e 
PR-URL: nodejs#17877
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
tniessen mentioned this pull request Jan 11, 2018
Closed
evanlucas pushed a commit that referenced this pull request Jan 17, 2018
errors: remove ERR_OUTOFMEMORY
df8cb40 
Backport-PR-URL: #18099
PR-URL: #17877
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
evanlucas mentioned this pull request Jan 30, 2018
Merged

MylesBorins commented Feb 27, 2018

Copy link
Copy Markdown
Contributor

Should this be backported to v8.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

tniessen added a commit to tniessen/node that referenced this pull request Mar 4, 2018
errors: remove ERR_OUTOFMEMORY
77b2e13 
PR-URL: nodejs#17877
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
tniessen mentioned this pull request Mar 4, 2018
Closed

tniessen commented Mar 4, 2018

Copy link
Copy Markdown
Member Author

@MylesBorins #19117

MylesBorins pushed a commit that referenced this pull request Mar 21, 2018
errors: remove ERR_OUTOFMEMORY
3e9f2c3 
Backport-PR-URL: #19117
PR-URL: #17877
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
errors: remove ERR_OUTOFMEMORY
5590088 
Backport-PR-URL: #19117
PR-URL: #17877
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
errors: remove ERR_OUTOFMEMORY
cbc8561 
Backport-PR-URL: #19117
PR-URL: #17877
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins mentioned this pull request May 2, 2018
Merged
ChALkeR mentioned this pull request Jun 25, 2018
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

errors Issues and PRs related to JavaScript errors originated in Node.js core.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL