http2: verify that a dependency cycle may exist - #17968
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
addaleax
approved these changes
Jan 3, 2018
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
jasnell
added a commit
that referenced
this pull request
Jan 5, 2018
PR-URL: #17968 Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2018
PR-URL: #17968 Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
PR-URL: #17968 Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
to jasnell/node
that referenced
this pull request
Jan 9, 2018
PR-URL: nodejs#17968 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
Copy link
Copy Markdown
Contributor
|
This lands cleanly on v8.x but the test fails. Likely blocked by another backport === release test-http2-priority-cycle- ===
Path: parallel/test-http2-priority-cycle-
(node:86045) ExperimentalWarning: The http2 module is an experimental API.
/Users/mborins/code/node/v8.x/test/parallel/test-http2-priority-cycle-.js:45
client.close();
^
TypeError: client.close is not a function
at Countdown (/Users/mborins/code/node/v8.x/test/parallel/test-http2-priority-cycle-.js:45:12)
at Countdown.dec (/Users/mborins/code/node/v8.x/test/common/countdown.js:19:22)
at ClientHttp2Stream.req.on (/Users/mborins/code/node/v8.x/test/parallel/test-http2-priority-cycle-.js:67:37)
at emitOne (events.js:116:13)
at ClientHttp2Stream.emit (events.js:211:7)
at emit (internal/http2/core.js:144:8)
at _combinedTickCallback (internal/process/next_tick.js:141:11)
at process._tickCallback (internal/process/next_tick.js:180:9)
|
Sorry, something went wrong.
kjin
pushed a commit
to kjin/node
that referenced
this pull request
May 1, 2018
Backport-PR-URL: nodejs#18050 PR-URL: nodejs#17968 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple test to verify that a priority dependency cycle may exist but won't crash anything.
Checklist
Affected core subsystem(s)
http2