FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

trace_events: stop tracing agent in process.exit() by AndreasMadsen · Pull Request #18005 · nodejs/node · GitHub

/ node Public

trace_events: stop tracing agent in process.exit() - #18005

Closed
AndreasMadsen wants to merge 2 commits into
nodejs:masterfrom
AndreasMadsen:trace-event-process-exit
ConversationCommits (2)ChecksFiles changed
Closed

trace_events: stop tracing agent in process.exit()#18005
AndreasMadsen wants to merge 2 commits into
nodejs:masterfrom
AndreasMadsen:trace-event-process-exit

Conversation

AndreasMadsen commented Jan 5, 2018

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

trace_events

AndreasMadsen added dont-land-on-v4.x trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. labels Jan 5, 2018
nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 5, 2018

AndreasMadsen commented Jan 5, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/12418/

AndreasMadsen commented Jan 5, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/12419/

bnoordhuis reviewed Jan 7, 2018
View reviewed changes
Comment thread test/parallel/test-trace-events-process-exit.js

proc.once('exit', common.mustCall(() => {
assert(common.fileExists(FILE_NAME));
fs.readFile(FILE_NAME, common.mustCall((err, data) => {

bnoordhuis Jan 7, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Use fs.readFileSync here, the async version is not guaranteed to complete. In fact, it probably doesn't but that goes unnoticed because the common.mustCall(...) isn't checked as you're already inside an exit handler.

cjihrig Jan 7, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is a child process 'exit' event, not process.exit(). fs.readFileSync() is probably a simpler idea either way though.

AndreasMadsen Jan 7, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is how all of the other trace-events tests work. I can change it, but at least it should be consistent.

AndreasMadsen commented Jan 8, 2018

Copy link
Copy Markdown
Member Author

Landed in 6aac05b

jasnell mentioned this pull request Jan 8, 2018
Closed
MylesBorins pushed a commit that referenced this pull request Jan 10, 2018
trace_events: stop tracing agent in process.exit()
366ede8 
PR-URL: #18005
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Jan 10, 2018
trace_events: stop tracing agent in process.exit()
7bf6be0 
PR-URL: #18005
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This was referenced Jan 16, 2018
Closed
Closed
gibfahn pushed a commit to gibfahn/node that referenced this pull request Jan 17, 2018
trace_events: stop tracing agent in process.exit()
4087dc8 
PR-URL: nodejs#18005
Backport-PR-URL: nodejs#18179
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2018
trace_events: stop tracing agent in process.exit()
1d3d1dd 
Backport-PR-URL: #18179
PR-URL: #18005
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis left review comments
cjihrig cjihrig approved these changes
jasnell jasnell approved these changes
gireeshpunathil gireeshpunathil approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL