FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

dns: add basic perf_hooks support by jasnell · Pull Request #18072 · nodejs/node · GitHub

/ node Public

dns: add basic perf_hooks support - #18072

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:dns-perf-hooks
Closed

dns: add basic perf_hooks support#18072
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:dns-perf-hooks

Conversation

jasnell commented Jan 10, 2018

Copy link
Copy Markdown
Member

emit simple perf_hooks timings for dns operations.

const { PerformanceObserver, performance } = require('perf_hooks');
const obs = new PerformanceObserver((items) => {
  const entry = items.getEntries()[0];
  console.log(entry.name, entry.duration);
  performance.clearDNS();
});
obs.observe({ entryTypes: ['dns'] });

dns.resolveAny('example.org', console.log);
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

dns, perf_hooks

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. perf_hooks Issues and PRs related to the implementation of the Performance Timing API. labels Jan 10, 2018

jasnell commented Jan 10, 2018

Copy link
Copy Markdown
Member Author

Will depend on #18046 and shouldn't land until that one does

jasnell added the blocked PRs that are blocked by other issues or PRs. label Jan 10, 2018
emit simple perf_hooks timings for dns operations.

```js
const { PerformanceObserver, performance } = require('perf_hooks');
const obs = new PerformanceObserver((items) => {
  const entry = items.getEntries()[0];
  console.log(entry.name, entry.duration);
  performance.clearDNS();
});
obs.observe({ entryTypes: ['dns'] });

dns.resolveAny('example.org', console.log);
```
jasnell removed the blocked PRs that are blocked by other issues or PRs. label Jan 24, 2018

jasnell commented Jan 24, 2018

Copy link
Copy Markdown
Member Author

BridgeAR commented Feb 1, 2018

Copy link
Copy Markdown
Member

@jasnell looks like there were some issues with the CI?

jasnell commented Feb 1, 2018

Copy link
Copy Markdown
Member Author

Yep, I'll be getting back to this very soon

jasnell added the wip Issues and PRs that are still a work in progress. label Feb 14, 2018
jasnell closed this Feb 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. perf_hooks Issues and PRs related to the implementation of the Performance Timing API. wip Issues and PRs that are still a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL