doc: update pushStream docs to use err first - #18088
Closed
jasnell wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
addaleax
approved these changes
Jan 10, 2018
mcollina
approved these changes
Jan 10, 2018
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
👍 for fast track |
Sorry, something went wrong.
lpinca
approved these changes
Jan 10, 2018
Copy link
Copy Markdown
Member
|
If you are on the way to fix http2 docs as result of #17406 you could also change the call to req.rstStream in sample code of http2stream.setTimeout (see https://nodejs.org/dist/latest-v9.x/docs/api/http2.html#http2_http2stream_settimeout_msecs_callback) |
Sorry, something went wrong.
danbev
approved these changes
Jan 11, 2018
jasnell
force-pushed
the
http2-fix-push-stream-docs
branch
from
69a4d5f to
17ee4c5
Compare
January 11, 2018 18:04
Copy link
Copy Markdown
Member
Author
|
@Flarna ... great catch... updated! |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
jasnell
added a commit
that referenced
this pull request
Jan 11, 2018
Refs: #17406 (comment) PR-URL: #18088 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
jasnell
added a commit
that referenced
this pull request
Jan 11, 2018
PR-URL: #18088 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
Refs: #17406 (comment) PR-URL: #18088 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
PR-URL: #18088 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Copy link
Copy Markdown
Contributor
|
is this accurate for the current 8.x implementation? |
Sorry, something went wrong.
kjin
pushed a commit
to kjin/node
that referenced
this pull request
May 1, 2018
Refs: nodejs#17406 (comment) PR-URL: nodejs#18088 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
kjin
pushed a commit
to kjin/node
that referenced
this pull request
May 1, 2018
PR-URL: nodejs#18088 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 2, 2018
Refs: #17406 (comment) Backport-PR-URL: #20456 PR-URL: #18088 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #17406 (comment)
/cc @mcollina
Checklist
Affected core subsystem(s)
http2, doc