Add Node Slack community to support options by hackygolucky · Pull Request #18191 · nodejs/node · GitHub

Checklist

documentation is changed or added
commit message follows commit guidelines

Adds the Node.js Slack Community to the list of support resources. Admins from the Slack community have agreed to posting and upholding the CoC and collaborating with the Moderation Team to uphold the guidelines. cc @alextes @ljharb

To note: would like to try this as well with #nodejs on Freenode IRC, but it takes a bit more work. So it stays listed in unofficial until/if we're able to confirm the same and have an admin team with bandwidth to support the existing community.

node-js.slack.com -> https://node-js.slack.com/
Without the protocol part, the URL is rendered as relative and causes 404.
The same: nodeslackers.io -> https://nodeslackers.io/ ?
However, both https://nodeslackers.io/ and http://nodeslackers.io/ are not accessible for me (nodeslackers.io’s server IP address could not be found).
Should it be http://www.nodeslackers.com/ ?

Looks like it! I will update. Thanks.

Should be! Good catch. Trying to improve this short term.

🎉

This should still be changed to .com 😄 .
http://www.nodeslackers.io -> http://www.nodeslackers.com/

I am not able to access nodeslackers.io either, www.nodeslackers.com is fine, though it is kind of scary that it is https-less.

Micro-nit: period after register

http://www.nodeslackers.io is not resolving for me, btw. Has it not yet been set up?

I get ERR_NAME_NOT_FOUND on http://www.nodeslackers.io should be changed to http://www.nodeslackers.com/

@benjamingr that's what I said 😅 .

@alextes right, and thanks for the review. I'm making that an explicit "changes requested" as a collaborator which means this PR can't be merged by accident (since it had approvals) until that issue is resolved.

It's more of another safety measure - apologies for not acknowledging your review in my "changes requested" :)

I see, in that case, let me just get my ego out of your helpful way 😅 .

@hackygolucky ... I assume the node.js slack is something set up by the Community Committee? Is there more documentation for it? E.g. who are the admins, what's it's purpose/intent, etc.

@jasnell it is not. It's set up by @justin . Active admins are him, me, and ljharb 😄. No further documentation.

@aredridel and @hackygolucky are also admins.

@jasnell in the discussions we'd had last year about IRC vs. Slack vs. something else, the consensus was to work with the existing communities because it is incredibly challenging bandwidth-wise to create from scratch when we have wonderful, active communities willing to participate and just...waiting for us to extend the olive branch to collaborate. In this case, this community Slack was already around for quite some time and welcoming to working groups that would like to work there. So we talked with the admins to ensure the steps could be taken to make moderation team feel comfortable with being considered a space project members can recommend users to for interacting and asking questions. It's the same reason #nodejs on IRC is considered unofficial. We haven't laid the groundwork for that...yet.

I think you've brought up a valid point of having a heartier reference place for this Slack, so I'll file another PR to further document that along with the admins.

Also I'm the worst I'm so sorry y'all even had to put the blocker on that dumb typo twice over :(

Haha, you're great @hackygolucky 😄. Don't worry about it 😉.

URL looks good 👌.

[nodeslackers.io] -> [nodeslackers.com] to sync with the URL :)

woo hoo! happy this is now being considered :) We've had this group for a couple years and it's always growing

@alextes fyi , you pinged the wrong Justin in that message above :)

LGTM but we likely need some indicator for the stackoverflow and slack community to indicate that they are not "official" foundation-provided resources. That can come later tho

It is still an unofficial resource and should be denoted as such.

@Fishrock123 @jasnell I might be reading this PR wrong, but I thought the purpose of this is to label it as official?

That said, I think we're all ok with having it labeled "unofficial" , but... what do we need to do actually do to receive the "official" label? We're 2-3 years in existence, >3,600 members in the group, it's active, has a healthy amount of moderation, and we're all willing to help out wherever needed.

We've also posted the CoC in the main channel, will send a periodic reminder of the rules/CoC, and all the admins have expressed a willingness to help enforce/collab with the Node folks.

On a side note, I'd openly welcome any folks from the Node committee to join the group and hang out to chat any concerns - and of course chat about Node :)

Though... this shouldn't be merged yet since the text still shows nodeslackers.io (link was changed correctly to .com)
https://github.com/nodejs/node/pull/18191/files#r162166903

@Fishrock123 I think we need to come up with some language that isn't 'official/unofficial' for this(admittedly, I brought this upon myself by just adopting that language so this is me suggesting an alternative). What we're talking about here is a sanctioned partnership and collaboration. If we're able to apply and moderate the CoC guidelines with a group(we currently can't do that in StackOverflow, but we are able to try for IRC just haven't done this). Everything doesn't need to be legally owned by the Node.js Foundation for people to participate and be a part of the community and for us within the project to feel comfortable with sending folks there. Much like NodeSchool.

It is leveraging the power of the community in a 'verified' sort of way, I suppose?

@Fishrock123 do you strongly disagree with the PR? If so, I guess it would be best to get a TSC vote?

I think we need to come up with some language that isn't 'official/unofficial'

That's fine by me - I have a suggestion: Not managed by Node.js. (Well, on second thought that really still just means unofficial, which is probably still correct. ¯\_(ツ)_/¯ )

And yes due to past things and the state of #node.js, I do feel pretty strong about this. The Slack should be listed alongside it. They are channels which are not officially managed by 'us' (The TSC / CommComm).

@hackygolucky would you be so kind and add the suggestion from @Fishrock123 to the entry?

Ping @hackygolucky

@Fishrock123 are you OK with landing this? And then we'll add a statement saying it's unofficial (same as StackOverflow).

I rebased due to conflicts and addressed the comment.

@Fishrock123 this is now in the "unofficial" part, so I guess you are now fine with this?

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite/472/

@Trott @jasnell @benjamingr @Fishrock123 PTAL

Micro-nit: There should be a trailing slash on the URL in this line.

Oh, much less of a nit and more important: This should be https. (Yes, it redirects. But still, that first request can send cookies unencrypted and have MITM content inserted and all that stuff.)

Addressed.

Yes, please!

I wish this URL was https. Looks like it's not served over HTTPS unfortunately. Leaving this comment here in case whoever runs it sees this and there's anything that can be done about it. Non-blocking on landing this.

😬 woops, yeah i'll get on that first thing tomorrow and let you know

New CI https://ci.nodejs.org/job/node-test-pull-request-lite/474/

Removing outdated review. PTAL

I am going to land this in ~24h if there are no objections from anyone.

Landed in 5c57cea 🎉

PR-URL: nodejs#18191 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

PR-URL: #18191 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 16, 2018

ljharb approved these changes Jan 16, 2018

View reviewed changes

vsemozhetbyt reviewed Jan 16, 2018

View reviewed changes

vsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Jan 16, 2018

alextes approved these changes Jan 16, 2018

View reviewed changes

alextes suggested changes Jan 16, 2018

View reviewed changes

Trott reviewed Jan 16, 2018

View reviewed changes

Trott approved these changes Jan 16, 2018

View reviewed changes

benjamingr approved these changes Jan 17, 2018

View reviewed changes

benjamingr requested changes Jan 17, 2018

View reviewed changes

vsemozhetbyt reviewed Jan 17, 2018

View reviewed changes

benjamingr approved these changes Jan 17, 2018

View reviewed changes

jasnell approved these changes Jan 18, 2018

View reviewed changes

Fishrock123 previously requested changes Jan 18, 2018

View reviewed changes

maclover7 force-pushed the master branch from bb5575a to 993b716 Compare January 26, 2018 22:02

cjihrig force-pushed the master branch from 993b716 to 082f952 Compare January 26, 2018 22:36

BridgeAR added the stalled Issues and PRs that are stalled. label Feb 16, 2018

fhinkel mentioned this pull request Mar 17, 2018

doc: mark StackOverflow as unofficial #19412

Closed

doc: add Slack community to support options

5f8b8a0

BridgeAR force-pushed the patch-1 branch from 095a9a7 to 5f8b8a0 Compare April 10, 2018 00:25

Trott reviewed Apr 10, 2018

View reviewed changes

Trott approved these changes Apr 10, 2018

View reviewed changes

Trott reviewed Apr 10, 2018

View reviewed changes

fixup: address comment

98b1602

trivikr approved these changes Apr 15, 2018

View reviewed changes

BridgeAR closed this Apr 26, 2018

MylesBorins mentioned this pull request May 8, 2018

v10.1.0 proposal #20606

Merged

               * [Questions tagged 'node.js' on StackOverflow][]
               * [#node.js channel on chat.freenode.net][]. See <http://nodeirc.info/> for more
                 information.
+              * [Node.js Slack Community](http://node-js.slack.com): Visit

               * [#node.js channel on chat.freenode.net][]. See <http://nodeirc.info/> for more
                 information.
+              * [Node.js Slack Community](http://node-js.slack.com): Visit
+                [nodeslackers.com](http://www.nodeslackers.com/) to register.

Add Node Slack community to support options by hackygolucky · Pull Request #18191 · nodejs/node · GitHub

Uh oh!

Uh oh!

Add Node Slack community to support options - #18191

Add Node Slack community to support options#18191hackygolucky wants to merge 2 commits intonodejs:masternodejs/node:masterfrom hackygolucky:patch-1hackygolucky/node-1:patch-1Copy head branch name to clipboard

Conversation

hackygolucky commented Jan 16, 2018

Checklist

Uh oh!

vsemozhetbyt Jan 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alextes left a comment

Choose a reason for hiding this comment

Uh oh!

alextes Jan 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joyeecheung commented Jan 16, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

benjamingr left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alextes commented Jan 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benjamingr commented Jan 17, 2018

Uh oh!

alextes commented Jan 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasnell commented Jan 17, 2018

Uh oh!

alextes commented Jan 17, 2018

Uh oh!

ljharb commented Jan 17, 2018

Uh oh!

hackygolucky commented Jan 17, 2018

Uh oh!

hackygolucky commented Jan 17, 2018

Uh oh!

alextes commented Jan 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jxm262 commented Jan 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasnell left a comment

Choose a reason for hiding this comment

Uh oh!

Fishrock123 left a comment

Choose a reason for hiding this comment

Uh oh!

jxm262 commented Jan 18, 2018

Uh oh!

hackygolucky commented Jan 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BridgeAR commented Feb 1, 2018

Uh oh!

Fishrock123 commented Feb 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BridgeAR commented Feb 13, 2018

Uh oh!

BridgeAR commented Mar 2, 2018

Uh oh!

Add Node Slack community to support options#18191
hackygolucky wants to merge 2 commits into
nodejs:masterfrom
hackygolucky:patch-1

vsemozhetbyt Jan 16, 2018 •
edited
Loading

alextes Jan 16, 2018 •
edited
Loading

benjamingr left a comment •
edited
Loading

alextes commented Jan 17, 2018 •
edited
Loading

alextes commented Jan 17, 2018 •
edited
Loading

alextes commented Jan 17, 2018 •
edited
Loading

jxm262 commented Jan 17, 2018 •
edited
Loading

hackygolucky commented Jan 18, 2018 •
edited
Loading

Fishrock123 commented Feb 2, 2018 •
edited
Loading