test: fix test/parallel/test-tls-server-verify.js on Windows CI - #18382
Closed
Trott wants to merge 1 commit into
Closed
test: fix test/parallel/test-tls-server-verify.js on Windows CI#18382Trott wants to merge 1 commit into
Trott wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Trott
force-pushed
the
fix-broken-windows-test
branch
from
a2b91a2 to
f80676d
Compare
January 25, 2018 22:52
The test runs two test cases at a time. This is not relevant to what the test is actually testing. Not sure why doing it that way causes a deadlock on some Windows servers, but running one at a time fixes it. Fixes: nodejs#18269
Trott
force-pushed
the
fix-broken-windows-test
branch
from
54c392f to
e3a4fd1
Compare
January 26, 2018 00:27
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
No longer in progress. Ready to land, I hope. PTAL. @nodejs/testing |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Sweet sweet passing test where it was failing before: ok 411 parallel/test-tls-server-verify
---
duration_ms: 10.681Fast track anyone? |
Sorry, something went wrong.
joyeecheung
approved these changes
Jan 26, 2018
Copy link
Copy Markdown
Member
|
cc @nodejs/crypto Should be safe to run them in parallel: commit 975e5956f06692259a0584e1e31d81d011e20320
Author: João Reis <reis@janeasystems.com>
Date: Fri May 22 14:28:11 2015 +0100
test: run tls-server-verify servers in parallel
Different servers must use different ports. Since we can count only on
common.PORT and common.PORT+1, run only 2 servers in parallel.
Fixes: https://github.com/nodejs/io.js/issues/1461
PR-URL: https://github.com/nodejs/io.js/pull/1836
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Sorry, something went wrong.
jasnell
approved these changes
Jan 26, 2018
cjihrig
approved these changes
Jan 26, 2018
Copy link
Copy Markdown
Contributor
|
I'm happy this is getting fixed but it only started failing reasonably recently and seems like it could be hiding a legitimate bug. The thing is, the real issue in this test might not even be tls but with child_process given its extensive usage. Maybe a TODO could be left to investigate why the test is failing on Windows when two parallel runTest are executed? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
On it. Hoping to have a known_issues test to submit in a different PR. |
Sorry, something went wrong.
Trott
added a commit
that referenced
this pull request
Jan 26, 2018
The test runs two test cases at a time. This is not relevant to what the test is actually testing. Not sure why doing it that way causes a deadlock on some Windows servers, but running one at a time fixes it. Fixes: #18269 PR-URL: #18382 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
The test runs two test cases at a time. This is not relevant to what the test is actually testing. Not sure why doing it that way causes a deadlock on some Windows servers, but running one at a time fixes it. Fixes: #18269 PR-URL: #18382 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 5, 2018
The test runs two test cases at a time. This is not relevant to what the test is actually testing. Not sure why doing it that way causes a deadlock on some Windows servers, but running one at a time fixes it. Fixes: #18269 PR-URL: #18382 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 7, 2018
The test runs two test cases at a time. This is not relevant to what the test is actually testing. Not sure why doing it that way causes a deadlock on some Windows servers, but running one at a time fixes it. Fixes: #18269 PR-URL: #18382 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 11, 2018
The test runs two test cases at a time. This is not relevant to what the test is actually testing. Not sure why doing it that way causes a deadlock on some Windows servers, but running one at a time fixes it. Fixes: #18269 PR-URL: #18382 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 12, 2018
The test runs two test cases at a time. This is not relevant to what the test is actually testing. Not sure why doing it that way causes a deadlock on some Windows servers, but running one at a time fixes it. Fixes: #18269 PR-URL: #18382 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 13, 2018
The test runs two test cases at a time. This is not relevant to what the test is actually testing. Not sure why doing it that way causes a deadlock on some Windows servers, but running one at a time fixes it. Fixes: #18269 PR-URL: #18382 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
The test runs two test cases at a time. This is not relevant to what the test is actually testing. Not sure why doing it that way causes a deadlock on some Windows servers, but running one at a time fixes it. Fixes: nodejs#18269 PR-URL: nodejs#18382 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test runs two test cases at a time. This is not relevant to what the
test is actually testing. Not sure why doing it that way causes a
deadlock on some Windows servers, but running one at a time fixes it.
Fixes: #18269
Checklist
Affected core subsystem(s)
test